Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composing validations stopped working in Ember 3.10 #650

Open
mydea opened this issue Jul 29, 2019 · 0 comments
Open

Composing validations stopped working in Ember 3.10 #650

mydea opened this issue Jul 29, 2019 · 0 comments

Comments

@mydea
Copy link

mydea commented Jul 29, 2019

Environment

  • Ember Version: 3.10
  • Ember CLI Version: 3.8.0
  • Ember CP Validations Version: 4.0.0-beta.9

Steps to Reproduce

Before I updated to ember-source 3.10 (and to make it work, ember-cp-validations 4.0.0-beta.9), we had code like this that worked fine:

const Validations = buildValidations(
  {
    ...
  }
);

export const SharedValidations = buildValidations(
  {
    ...
  }
);

export default Model.extend(Validations, SharedValidations, { });

After upgrading, this stopped working. I ended up just manually merging the validations and repeating the declarations, but wanted to let you know that this happened - it's also not really well documented, so not sure if that was even supposed to work (although it was a quite handy feature...!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant