Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Ember project not launching with ember electron #51

Closed
kdawgwilk opened this issue Apr 8, 2016 · 9 comments
Closed

Existing Ember project not launching with ember electron #51

kdawgwilk opened this issue Apr 8, 2016 · 9 comments

Comments

@kdawgwilk
Copy link

Here is my current versions

package.json electron dependency versions
"electron-packager": "6.0.0",
"electron-prebuilt": "0.37.5",
"electron-rebuild": "1.1.3",
"ember-electron": "1.3.2",

$ ember -v
ember-cli: 2.4.3
node: 4.4.2
os: darwin x64

After running ember install ember-electron and configuring project trying to run ember electron gives me this:

screen shot 2016-04-07 at 11 47 08 pm

@kdawgwilk
Copy link
Author

Also after running ember electron:package --platform darwin and trying to launch app I get this

screen shot 2016-04-07 at 11 56 55 pm

@felixrieseberg
Copy link
Collaborator

Thanks for reporting! I'ts a bit hard to see because of the whiteouts, but is there a comma in the app name? I'd assume that the trouble is that the app and the generator disagree over where the app is located. To fix:

  • In package.json, ensure that all names are filesystem-compliant (ideally: A-Z;0-9)
  • Check your filesystem, especially electron-builds. Where is the app?

@felixrieseberg
Copy link
Collaborator

Oh, and if you changed your app's name, you should probably run ember g ember-electron again.

@kdawgwilk
Copy link
Author

Yeah sorry about the white out 😁 those are actually the letter y and the name is made up of just letters and - ? Any other ideas?

@felixrieseberg
Copy link
Collaborator

It's definitely the app name - or, if you're sure that the files are there on disk, you might have an error in that file that keeps it from being successfully exported.

@kdawgwilk
Copy link
Author

Which file would have the error? electron.js?

@SSS2557
Copy link

SSS2557 commented Apr 14, 2016

for me, with the same versions and OS, the electron app is just shown in the dock but no app window pops up :(

No errors too. I tried packaging it and opening the executable but still the same.

And to add to this information, the tests ember electron:test work just fine. Just not the app itself

Update: I forgot I was pointing to some express-server accommodating code. I probably need to re-try

@kdawgwilk
Copy link
Author

I also was able to run the tests fine not sure why one would run and the other not

@anulman
Copy link
Collaborator

anulman commented Feb 27, 2017

Closing due to age; please do reopen if this is still an issue 😄

@anulman anulman closed this as completed Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants