Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will not load more if still in view #10

Closed
bruce opened this issue Apr 7, 2015 · 5 comments
Closed

Will not load more if still in view #10

bruce opened this issue Apr 7, 2015 · 5 comments

Comments

@bruce
Copy link
Contributor

bruce commented Apr 7, 2015

This is a bit of an edge case, but in the event you set perPage low enough so that it would take more than two requests to fill the viewport, it simply stops after the second page of results is loaded.

My expectation is that it would continue to load items until the infinity-loader was pushed out of view or the results were all retrieved/displayed.

@hhff
Copy link
Collaborator

hhff commented Apr 7, 2015

You're saying that after the first call to infinityLoad, if the loader is still in view, it won't retrigger a new load automatically, right?

Should be simple enough to solve - my main concern is keeping it inline with "actions up, data down"

@bruce
Copy link
Contributor Author

bruce commented Apr 8, 2015

Correct. My naïve guess was that it may have had to do with a debounce or a run once, but I didn't have a chance to investigate further. Thanks!

@hhff
Copy link
Collaborator

hhff commented Apr 8, 2015

I'll look into this shortly, I reckon observing the length of infinityModel and checking if it's still in view (and loading more if so) directly after the length changes should do the trick

@hhff
Copy link
Collaborator

hhff commented Apr 8, 2015

(from the infinity-loader, that is)

@kellyselden
Copy link
Collaborator

fixed in #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants