Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The intercom adapter does not load the Intercom API correctly #109

Closed
Artmann opened this issue Nov 9, 2016 · 1 comment
Closed

The intercom adapter does not load the Intercom API correctly #109

Artmann opened this issue Nov 9, 2016 · 1 comment

Comments

@Artmann
Copy link
Contributor

Artmann commented Nov 9, 2016 •
edited

The intercom adapter does not always load the Intercom API correctly as it's dependent on window.load.
@wecc
Copy link
Contributor

wecc commented Nov 9, 2016

At the end of this line the Intercom JS snippet depends on window load/onload. However, when the adapter is initialized this event has already been triggered.

We should be able to replace that if block with a single call to l().

@Artmann Artmann mentioned this issue Nov 10, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Artmann @wecc