Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate moment module to ember-cli-moment-shim #55

Closed
seanpdoyle opened this issue Jul 17, 2015 · 6 comments
Closed

Delegate moment module to ember-cli-moment-shim #55

seanpdoyle opened this issue Jul 17, 2015 · 6 comments

Comments

@seanpdoyle
Copy link
Contributor

I've opened a PR against ember-cli-moment-shim to move ember-moment's moment module code to ember-cli-moment-shim.

Could you look over that PR?

While testing locally, I'm trying to import moment from 'moment' to no avail.

@jasonmit
Copy link
Collaborator

While testing locally, I'm trying to import moment from 'moment' to no avail.

While testing ember-moment or ember-moment-shim?

@seanpdoyle
Copy link
Contributor Author

@jasonmit while testing an ember-cli app that is consuming ember-cli-moment-shim.

@stefanpenner I'm looping you into this both because:

  • I've hoisted the code from this repo, and plan on making this addon delegate to ember-cli-moment-shim once that PR is merged
  • I largely don't know what I'm doing when it comes to bower and ember-cli addons interact

@stefanpenner
Copy link
Collaborator

FYI: https://github.com/stefanpenner/ember-moment/blob/4b64dbe6c23a8ef45552392cbe24fd773cac1328/index.js#L40-L42 does basically 0 things now, it did in the past and it may in the future.

@jasonmit
Copy link
Collaborator

This is resolved on both ember-moment and ember-cli-moment-shim

@seanpdoyle
Copy link
Contributor Author

👏 nice work you two.

@stefanpenner
Copy link
Collaborator

its all @jasonmit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants