-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate moment
module to ember-cli-moment-shim
#55
Comments
While testing ember-moment or ember-moment-shim? |
@jasonmit while testing an ember-cli app that is consuming @stefanpenner I'm looping you into this both because:
|
FYI: https://github.com/stefanpenner/ember-moment/blob/4b64dbe6c23a8ef45552392cbe24fd773cac1328/index.js#L40-L42 does basically 0 things now, it did in the past and it may in the future. |
This is resolved on both ember-moment and ember-cli-moment-shim |
👏 nice work you two. |
its all @jasonmit :) |
I've opened a PR against ember-cli-moment-shim to move ember-moment's moment module code to ember-cli-moment-shim.
Could you look over that PR?
While testing locally, I'm trying to
import moment from 'moment'
to no avail.The text was updated successfully, but these errors were encountered: