Skip to content

Commit

Permalink
fix: remove ember-copy
Browse files Browse the repository at this point in the history
  • Loading branch information
knownasilya committed Oct 6, 2020
1 parent 7138ee2 commit 0977897
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 19 deletions.
9 changes: 4 additions & 5 deletions addon/services/page-title-list.js
Expand Up @@ -3,7 +3,6 @@ import { getOwner } from '@ember/application';
import { scheduleOnce } from '@ember/runloop';
import Service, { inject as service } from '@ember/service';
import { set, computed } from '@ember/object';
import { copy } from 'ember-copy';
import { capitalize } from '@ember/string';
import { isPresent } from '@ember/utils';

Expand Down Expand Up @@ -99,7 +98,7 @@ export default class PageTitleListService extends Service {
let tokenForId = this.tokens.findBy('id', token.id);
if (tokenForId) {
let index = this.tokens.indexOf(tokenForId);
let tokens = copy(this.tokens);
let tokens = [...this.tokens];
let previous = tokenForId.previous;
token.previous = previous;
token.next = tokenForId.next;
Expand All @@ -120,7 +119,7 @@ export default class PageTitleListService extends Service {

this.applyTokenDefaults(token);

let tokens = copy(this.tokens);
let tokens = [...this.tokens];
tokens.push(token);
set(this, 'tokens', A(tokens));
}
Expand All @@ -138,7 +137,7 @@ export default class PageTitleListService extends Service {

token.previous = token.next = null;

let tokens = A(copy(this.tokens));
let tokens = A([...this.tokens]);
tokens.removeObject(token);
set(this, 'tokens', A(tokens));
}
Expand Down Expand Up @@ -178,7 +177,7 @@ export default class PageTitleListService extends Service {
}
let lastToken = group[0];
if (lastToken) {
token = copy(token);
token = Object.assign({}, token);
token.separator = lastToken.separator;
}
group.unshift(token);
Expand Down
7 changes: 3 additions & 4 deletions package.json
Expand Up @@ -29,8 +29,7 @@
"release": "standard-version"
},
"dependencies": {
"ember-cli-babel": "^7.22.1",
"ember-copy": "^1.0.0"
"ember-cli-babel": "^7.22.1"
},
"devDependencies": {
"@ember/optional-features": "^2.0.0",
Expand Down Expand Up @@ -59,10 +58,10 @@
"ember-resolver": "^8.0.2",
"ember-source": "~3.21.1",
"ember-source-channel-url": "^3.0.0",
"ember-template-lint": "^2.12.0",
"ember-template-lint": "^2.13.0",
"ember-truth-helpers": "^2.1.0",
"ember-try": "^1.4.0",
"eslint": "^7.9.0",
"eslint": "^7.10.0",
"eslint-plugin-ember": "^9.0.0",
"eslint-plugin-node": "^11.1.0",
"loader.js": "^4.7.0",
Expand Down
20 changes: 10 additions & 10 deletions yarn.lock
Expand Up @@ -5924,10 +5924,10 @@ ember-source@~3.21.1:
semver "^6.1.1"
silent-error "^1.1.1"

ember-template-lint@^2.12.0:
version "2.12.1"
resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-2.12.1.tgz#718b6141b2001ca6e74764f7f59d8554a86473f4"
integrity sha512-LbnDoHRXGPPNPACvSAatkZVPY9jBFlobdf7I7kdvSD8/W9c2/XDDejAVhHnbWFhPn+U12bA7Lgt505Vq6D7hLw==
ember-template-lint@^2.13.0:
version "2.13.0"
resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-2.13.0.tgz#560b5a8a25db56a16ffee1604efc9d79e8f54536"
integrity sha512-68VgGaocC++BA4D90mKZMPoUBA2kRTEXcHMoWHnXqtRzXP5S35y2m9+nEUHdX9YWjGJTFHW5Tga58gvrvdl3wQ==
dependencies:
chalk "^4.0.0"
ember-template-recast "^4.1.5"
Expand Down Expand Up @@ -6268,7 +6268,7 @@ eslint-scope@^4.0.0:
esrecurse "^4.1.0"
estraverse "^4.1.1"

eslint-scope@^5.1.0:
eslint-scope@^5.1.1:
version "5.1.1"
resolved "https://registry.yarnpkg.com/eslint-scope/-/eslint-scope-5.1.1.tgz#e786e59a66cb92b3f6c1fb0d508aab174848f48c"
integrity sha512-2NxwbF/hZ0KpepYN0cNbo+FN6XoK7GaHlQhgx/hIZl6Va0bF45RQOOwhLIy8lQDbuCiadSLCBnH2CFYquit5bw==
Expand All @@ -6288,10 +6288,10 @@ eslint-visitor-keys@^1.0.0, eslint-visitor-keys@^1.1.0, eslint-visitor-keys@^1.3
resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.3.0.tgz#30ebd1ef7c2fdff01c3a4f151044af25fab0523e"
integrity sha512-6J72N8UNa462wa/KFODt/PJ3IU60SDpC3QXC1Hjc1BXXpfL2C9R5+AU7jhe0F6GREqVMh4Juu+NY7xn+6dipUQ==

eslint@^7.9.0:
version "7.9.0"
resolved "https://registry.yarnpkg.com/eslint/-/eslint-7.9.0.tgz#522aeccc5c3a19017cf0cb46ebfd660a79acf337"
integrity sha512-V6QyhX21+uXp4T+3nrNfI3hQNBDa/P8ga7LoQOenwrlEFXrEnUEE+ok1dMtaS3b6rmLXhT1TkTIsG75HMLbknA==
eslint@^7.10.0:
version "7.10.0"
resolved "https://registry.yarnpkg.com/eslint/-/eslint-7.10.0.tgz#494edb3e4750fb791133ca379e786a8f648c72b9"
integrity sha512-BDVffmqWl7JJXqCjAK6lWtcQThZB/aP1HXSH1JKwGwv0LQEdvpR7qzNrUT487RM39B5goWuboFad5ovMBmD8yA==
dependencies:
"@babel/code-frame" "^7.0.0"
"@eslint/eslintrc" "^0.1.3"
Expand All @@ -6301,7 +6301,7 @@ eslint@^7.9.0:
debug "^4.0.1"
doctrine "^3.0.0"
enquirer "^2.3.5"
eslint-scope "^5.1.0"
eslint-scope "^5.1.1"
eslint-utils "^2.1.0"
eslint-visitor-keys "^1.3.0"
espree "^7.3.0"
Expand Down

0 comments on commit 0977897

Please sign in to comment.