fix: Update Ember codemod v3.20.2...v3.21.2

BREAKING CHANGE: Drop support for Ember < 3.16
ember-cli · Oct 6, 2020 · f48a437 · f48a437
1 parent 94098b8
commit f48a437
Show file tree

Hide file tree

Showing 9 changed files with 44 additions and 53 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -3,7 +3,7 @@ language: node_js
 node_js:
   # we recommend testing addons with the same minimum supported node version as Ember CLI
   # so that your addon works for all apps
-  - "10"
+  - '10'
 
 dist: xenial
 
@@ -33,22 +33,21 @@ jobs:
 
   include:
     # runs linting and tests with current locked deps
-    - stage: "Tests"
-      name: "Tests"
+    - stage: 'Tests'
+      name: 'Tests'
       script:
         - yarn lint
         - yarn test:ember
 
-    - stage: "Additional Tests"
-      name: "Floating Dependencies"
+    - stage: 'Additional Tests'
+      name: 'Floating Dependencies'
       install:
         - yarn install --no-lockfile --non-interactive
       script:
         - yarn test:ember
 
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.12
     - env: EMBER_TRY_SCENARIO=ember-lts-3.16
     - env: EMBER_TRY_SCENARIO=ember-lts-3.20
     - env: EMBER_TRY_SCENARIO=ember-release

diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ ember install ember-page-title
 
 ### Compatibility
 
-- Ember.js v3.12 or above
+- Ember.js v3.16 or above
 - Ember CLI v2.13 or above
 - Node.js v10 or above
 

diff --git a/config/ember-try.js b/config/ember-try.js
@@ -6,14 +6,6 @@ module.exports = async function () {
   return {
     useYarn: true,
     scenarios: [
-      {
-        name: 'ember-lts-3.12',
-        npm: {
-          devDependencies: {
-            'ember-source': '~3.12.0',
-          },
-        },
-      },
       {
         name: 'ember-lts-3.16',
         npm: {

diff --git a/package.json b/package.json
@@ -29,7 +29,7 @@
     "release": "standard-version"
   },
   "dependencies": {
-    "ember-cli-babel": "^7.22.0",
+    "ember-cli-babel": "^7.22.1",
     "ember-copy": "^1.0.0"
   },
   "devDependencies": {
@@ -40,24 +40,24 @@
     "broccoli-asset-rev": "^3.0.0",
     "ember-auto-import": "^1.6.0",
     "ember-autoresize": "^1.3.1",
-    "ember-cli": "~3.20.0",
+    "ember-cli": "~3.21.2",
     "ember-cli-code-coverage": "^1.0.0",
     "ember-cli-dependency-checker": "^3.2.0",
     "ember-cli-fastboot": "^2.2.3",
     "ember-cli-fastboot-testing": "^0.4.0",
     "ember-cli-github-pages": "^0.2.0",
-    "ember-cli-htmlbars": "^5.3.0",
+    "ember-cli-htmlbars": "^5.3.1",
     "ember-cli-inject-live-reload": "^2.0.2",
     "ember-cli-sass": "^10.0.1",
-    "ember-cli-uglify": "^3.0.0",
+    "ember-cli-terser": "^4.0.0",
     "ember-cli-update": "^0.54.0",
     "ember-disable-prototype-extensions": "^1.1.3",
     "ember-inline-svg": "^1.0.0",
     "ember-load-initializers": "^2.1.1",
     "ember-maybe-import-regenerator": "^0.1.6",
     "ember-qunit": "^4.6.0",
-    "ember-resolver": "^8.0.0",
-    "ember-source": "~3.20.2",
+    "ember-resolver": "^8.0.2",
+    "ember-source": "~3.21.1",
     "ember-source-channel-url": "^3.0.0",
     "ember-template-lint": "^2.12.0",
     "ember-try": "^1.4.0",

diff --git a/tests/dummy/app/index/template.hbs b/tests/dummy/app/index/template.hbs
@@ -52,7 +52,7 @@
       </h2>
       <div class='grid'>
         <PageTitlePane as |p|>
-          <p.matryoshka @items={{this.model.tokens}} as |token|>
+          <p.matryoshka @items={{@model.tokens}} as |token|>
             <code>
               {{page-title
                 token.value
@@ -101,7 +101,7 @@
               }}
             </code>
           </p.matryoshka>
-          <button type='button' {{on 'click' (fn this.add this.model.tokens)}}>
+          <button type='button' {{on 'click' (fn this.add @model.tokens)}}>
             Add title
           </button>
         </PageTitlePane>
@@ -121,16 +121,16 @@
             </code>
           </p>
           <p>
-            This sets the title for your application. When your application loads, you should see the title &ldquo;{{this.model.title
+            This sets the title for your application. When your application loads, you should see the title &ldquo;{{@model.title
             }}&rdquo; appear in the window. Try changing the value below to change the title of this page.
           </p>
 
-          <Input type='text' value={{this.model.title}} placeholder='My App' />
+          <Input type='text' value={{@model.title}} placeholder='My App' />
         </div>
 
         <WindowPane @title='templates/application.hbs'>
           <code>
-            {{highlight '{{page-title "' this.model.title '"}}'}}
+            {{highlight '{{page-title "' @model.title '"}}'}}
           </code>
         </WindowPane>
       </div>
@@ -143,15 +143,15 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}}>
+          <p.template @title={{@model.title}}>
             <code>
-              {{highlight '{{page-title "' this.model.title '"}}'}}
+              {{highlight '{{page-title "' @model.title '"}}'}}
             </code>
             <p.template title='Posts'>
               <code>
                 {{highlight '{{page-title "Posts"}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
                   {{highlight '{{page-title post.title}}'}}
                 </code>
@@ -175,19 +175,19 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}} @separator='>'>
+          <p.template @title={{@model.title}} @separator='>'>
             <code>
               {{highlight
                 '{{page-title "'
-                this.model.title
+                @model.title
                 '" separator=" > "}}'
               }}
             </code>
             <p.template @title='Posts'>
               <code>
                 {{highlight '{{page-title "Posts"}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
                   {{highlight '{{page-title post.title}}'}}
                 </code>
@@ -205,19 +205,19 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}} @separator=':'>
+          <p.template @title={{@model.title}} @separator=':'>
             <code>
               {{highlight
                 '{{page-title "'
-                this.model.title
+                @model.title
                 '" separator=": "}}'
               }}
             </code>
             <p.template @title='Posts' @separator='>'>
               <code>
                 {{highlight '{{page-title "Posts" separator=" > "}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
                   {{highlight '{{page-title post.title}}'}}
                 </code>
@@ -245,15 +245,15 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}} @prepend={{true}}>
+          <p.template @title={{@model.title}} @prepend={{true}}>
             <code>
-              {{highlight '{{page-title "' this.model.title '" prepend=true}}'}}
+              {{highlight '{{page-title "' @model.title '" prepend=true}}'}}
             </code>
             <p.template @title='Posts'>
               <code>
                 {{highlight '{{page-title "Posts"}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
                   {{highlight '{{page-title post.title}}'}}
                 </code>
@@ -271,15 +271,15 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}}>
+          <p.template @title={{@model.title}}>
             <code>
-              {{highlight '{{page-title "' this.model.title '"}}'}}
+              {{highlight '{{page-title "' @model.title '"}}'}}
             </code>
             <p.template @title='Posts' @prepend={{true}}>
               <code>
                 {{highlight '{{page-title "Posts" prepend=true}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
                   {{highlight '{{page-title post.title}}'}}
                 </code>
@@ -307,17 +307,17 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}}>
+          <p.template @title={{@model.title}}>
             <code>
-              {{highlight '{{page-title "' this.model.title '"}}'}}
+              {{highlight '{{page-title "' @model.title '"}}'}}
             </code>
             <p.template @title='Posts' @replace={{true}}>
               <code>
                 {{highlight '{{page-title "Posts" replace=true}}'}}
               </code>
-              <p.template @title={{this.model.post.title}}>
+              <p.template @title={{@model.post.title}}>
                 <code>
-                  {{highlight '{{page-title this.model.post.title}}'}}
+                  {{highlight '{{page-title @model.post.title}}'}}
                 </code>
               </p.template>
             </p.template>
@@ -333,16 +333,16 @@
         </div>
 
         <PageTitlePane as |p|>
-          <p.template @title={{this.model.title}}>
+          <p.template @title={{@model.title}}>
             <code>
-              {{highlight '{{page-title "' this.model.title '"}}'}}
+              {{highlight '{{page-title "' @model.title '"}}'}}
             </code>
-            <p.template @title={{concat 'Posts | ' this.model.post.title}}>
+            <p.template @title={{concat 'Posts | ' @model.post.title}}>
               <code>
                 {{highlight '{{page-title "Posts"}}'}}
               </code>
               <code>
-                {{highlight '{{page-title this.model.post.title}}'}}
+                {{highlight '{{page-title @model.post.title}}'}}
               </code>
             </p.template>
           </p.template>

diff --git a/tests/dummy/app/templates/author.hbs b/tests/dummy/app/templates/author.hbs
@@ -1,2 +1,2 @@
 {{page-title 'Authors' prepend=false separator=' < '}}
-{{page-title this.model.name}}
+{{page-title @model.name}}
diff --git a/tests/dummy/app/templates/feed.hbs b/tests/dummy/app/templates/feed.hbs
@@ -1,4 +1,4 @@
-{{page-title this.model.name ' (' this.model.handle ')' replace=true}}
+{{page-title @model.name ' (' @model.handle ')' replace=true}}
 
 <LinkTo @route='feed' @model='tomster' id='tomster'>
   @tomster

diff --git a/tests/dummy/app/templates/post.hbs b/tests/dummy/app/templates/post.hbs
@@ -1,2 +1,2 @@
 {{page-title 'Posts'}}
-{{page-title this.model.title}}
+{{page-title @model.title}}
diff --git a/tests/dummy/config/ember-cli-update.json b/tests/dummy/config/ember-cli-update.json
@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.20.2",
+      "version": "3.21.2",
       "blueprints": [
         {
           "name": "addon",