Smoke tests are getting JDK_IMPL=temurin unlike other jobs

[sxa]

What are you trying to do? Run smoke test jobs successfully in the nightly pipelines

Expected behaviour: Builds success

Observed behaviour: Builds fail as theyt are being passed JDK_IMPL=temurin instead of the other test jobs which are getting JDK_IMPL=hotspot - basically the smoke tests do not seem to be subject to

ci-jenkins-pipelines/pipelines/build/common/openjdk_build_pipeline.groovy

Line 184 in 31ad2d4

if (buildConfig.VARIANT == "temurin") {

, which is odd since that code is in getCommonTestJobParams which is called from getSmokeTestJobParams and getAQATestJobParams

Any other comments:

[sxa]

@sophia-guo Do you know why the temurin->hotspot parameter switch isn't taking effect for the Smoke tests but is for the other test jobs?

[sxa]

OK I'm now even more confused by what's happening ...

If I run https://ci.adoptopenjdk.net/view/work-in-progress/job/SXA-LinuxARMbuildTest/, which is a straight copy of https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-aarch64-temurin/, it passed JVM_IMPL=hotspot into the generated smoke test job which passed, but it doesn't for the smoke test on the original pipeline

@sophia-guo Any idea why this is happening?

[sophia-guo]

ci-jenkins-pipelines/pipelines/build/common/openjdk_build_pipeline.groovy

Line 184 in 31ad2d4

if (buildConfig.VARIANT == "temurin") {

is in PR #245, which is to fix this. The failed smoke tests were generated before this fix and need to be regenerated.

[sophia-guo]

Note, recent AQA_AUTO_GEN only work for aqa test jobs, which doesn't work for smoke test job.

[sxa]

ci-jenkins-pipelines/pipelines/build/common/openjdk_build_pipeline.groovy

Line 184 in 31ad2d4

if (buildConfig.VARIANT == "temurin") {

is in PR #245, which is to fix this. The failed smoke tests were generated before this fix and need to be regenerated.

Hmmm OK I'm a bit confused as to how this works then as I thought that code was in the pipeline code that sets the parameters that are used to call the smoke test job - I'd run the regeneration of the build pipeline so thought that would change the input to the smoke test job, but I'll try deleting the smoke test job and retrying ...

[sxa]

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-aarch64-temurin/8/console

[sxa]

LGTM - I'll delete all the temurin_SmokeTest jobs and let them be regenerated. Backup created as temurin_SmokeTests.tar.xz in the jobs directory on the jenkins master.

[sxa]

Now working.