Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align jenkins jobs' parameters' names #433

Open
zdtsw opened this issue Oct 5, 2022 · 2 comments · May be fixed by #440
Open

Align jenkins jobs' parameters' names #433

zdtsw opened this issue Oct 5, 2022 · 2 comments · May be fixed by #440
Labels
enhancement good first issue

Comments

@zdtsw
Copy link
Contributor

zdtsw commented Oct 5, 2022

Some parameters we use for openjdk pipeline and downstream build jobs are not matching.

It is good to align them to make code more clear , e.g:

  • cleanWorkspaceBeforeBuild vs CLEAN_WORKSPACE
  • useAdoptBashScripts vs USE_ADOPT_SHELL_SCRIPTS

The goal is to

  1. change CLEAN_WORKSPACE to CLEAN_WORKSPACE_BEFORE_BUILD , change useAdoptBashScripts to useAdoptShellScripts
  2. update document, comments
@sakshi1215
Copy link
Contributor

Hi @zdtsw, I am potential outreachy candidate can you assignt this issue to me?

@sakshi1215 sakshi1215 linked a pull request Oct 10, 2022 that will close this issue
Draft
@zdtsw zdtsw mentioned this issue Nov 24, 2022
Draft
@zdtsw
Copy link
Contributor Author

zdtsw commented Nov 24, 2022

@sakshi1215 do you want to finalize this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
2024 1Q Adoptium Plan
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rename argument parameters sakshi1215/ci-jenkins-pipelines
3 participants
@zdtsw @andrew-m-leonard @sakshi1215