Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK8 OpenJ9 builds not using native crypto #1039

Closed
smlambert opened this issue Apr 15, 2019 · 5 comments
Closed

JDK8 OpenJ9 builds not using native crypto #1039

smlambert opened this issue Apr 15, 2019 · 5 comments
Assignees
Labels
bug Issues that are problems in the code as reported by the community reported to Eclipse OpenJ9 Issues that have been reported upstream to the OpenJ9 group
Milestone

Comments

@smlambert
Copy link
Contributor

Platform:
linux

Architecture:
x64

FYI @sxa555

There appear to be some changes to build scripts which have broken JDK8 OpenJ9 builds from using native crypto (openssl) library. Other platforms seem fine, JDK11 seems fine.

Failed job:
https://ci.adoptopenjdk.net/view/Test_functional/job/openjdk8_j9_functionaltest_x86-64_linux/68/tapResults/

Output from test:
[OUT] Crypto test COMPLETED
[ERR] Warning: Native crypto library load failed. Using Java crypto implementation
[ERR] Warning: Native crypto library load failed. Using Java crypto implementation

Success condition was not found: [Output match: using native crypto library]

@smlambert smlambert added the bug Issues that are problems in the code as reported by the community label Apr 15, 2019
@sxa sxa self-assigned this Apr 15, 2019
@sxa
Copy link
Member

sxa commented Apr 15, 2019

That failure is on Debian 8 which appears to ship with openssl 1.0.1t which is not supported by the OpenJ9 SSL code.

While we could install 1.0.2 on there (The same issue exists on RHEL6 and since that's our build system we have on there - adoptium/infrastructure#760) it becomes a matter of what we want to support, as we are not reshipping openssl libraries ourselves on Linux platforms.

@karianna karianna added this to TODO in temurin-build via automation Apr 15, 2019
@smlambert
Copy link
Contributor Author

Openssl 1.0.2 is the LTS version which is likely why it was (arbitrarily) selected as the one supported by OpenJ9 ssl code (I am wondering if Openssl 1.0.1 is patched on Debian/RHEL6). Will raise discussion in OpenJ9, re: lowest common denominator of supported version.

@sxa
Copy link
Member

sxa commented Apr 16, 2019

I'm privately building a version of OpenJ9/JDK8 at the moment with the version checks disabled. This will allow us to at least load with the older version.

@sxa sxa added the reported to Eclipse OpenJ9 Issues that have been reported upstream to the OpenJ9 group label Apr 16, 2019
@karianna karianna added this to the July 2019 milestone Jul 5, 2019
@karianna karianna modified the milestones: July 2019, August 2019 Aug 6, 2019
@karianna karianna modified the milestones: August 2019, September 2019 Sep 2, 2019
@karianna karianna modified the milestones: September 2019, October 2019 Oct 4, 2019
@karianna karianna modified the milestones: October 2019, November 2019 Nov 3, 2019
@sxa
Copy link
Member

sxa commented Dec 3, 2019

@smlambert Is this still an issue? According to eclipse-openj9/openj9-docs#260 support was put in for supporting 1.0.1. I'm going to close this for now as I believe it's fixed. We are, however, looking at adding 1.0.2 into our Debian playbooks going forwards - see https://github.com/AdoptOpenJDK/openjdk-infrastructure/pull/1021/files#diff-2fe4aec9807df5d1be9c28ca7c6d32d5 (I have no knowledge of how the existing Debian machines were set up since George has repeatedly failed to send us the set up docs so we're redeveloping them from scratch for Debian).

@sxa sxa closed this as completed Dec 3, 2019
temurin-build automation moved this from TODO to Done Dec 3, 2019
@smlambert
Copy link
Contributor Author

Thanks @sxa555 ! I think this is addressed, will open a fresh separate issue if anything new crops up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community reported to Eclipse OpenJ9 Issues that have been reported upstream to the OpenJ9 group
Projects
No open projects
temurin-build
  
Done
Development

No branches or pull requests

3 participants