Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust regexs for release tool job #3449

Open
sxa opened this issue Aug 7, 2023 · 2 comments
Open

Adjust regexs for release tool job #3449

sxa opened this issue Aug 7, 2023 · 2 comments
Labels
testing Issues that enhance or fix our test suites

Comments

@sxa
Copy link
Member

sxa commented Aug 7, 2023

          Look at recommendations for expressions for filenames in RELEASING.md vs the examples shown in the job (Particularly in terms of the sources tarball and inclusion of testimage files)

Originally posted by @sxa in adoptium/adoptium#240 (comment)

Possibly only have the information in the job parameter description or RELEASING.md ... Could be either in the releasing guide or the job (Perhaps better in the job as you have it on screen when you're running it). Or sort it out properly via a higher level release job that has fewer parameters and is easier to run, encompassing all of the appropriate logic.

@adamfarley
Copy link
Contributor

As a follow-on to this, could we move the regular expressions into source control and have the user pick platform names rather than attempting to get the regex correct?

@sxa
Copy link
Member Author

sxa commented Sep 1, 2023

regular expressions into source control

That would be part of a separate effort to make this a pipeline job which is already underway by @sophia-guo IIRC

have the user pick platform names rather than attempting to get the regex correct?

Yep that was the goal of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues that enhance or fix our test suites
Projects
None yet
Development

No branches or pull requests

2 participants