Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beautified squared letters #9

Closed
djstrong opened this issue Nov 21, 2022 · 2 comments
Closed

Beautified squared letters #9

djstrong opened this issue Nov 21, 2022 · 2 comments

Comments

@djstrong
Copy link

I am investigating names consisted of squared letters. However, for some letters theirs beautified version is different than others:
image
https://adraffy.github.io/ens-normalize.js/test/resolver.html#%F0%9F%85%B0%F0%9F%85%B1%F0%9F%85%B2%F0%9F%85%B3%F0%9F%85%B4%F0%9F%85%B5%F0%9F%85%B6%F0%9F%85%B7%F0%9F%85%B8%F0%9F%85%B9%F0%9F%85%BA%F0%9F%85%BB%F0%9F%85%BC%F0%9F%85%BD%F0%9F%85%BE%F0%9F%85%BF%F0%9F%86%80%F0%9F%86%81%F0%9F%86%82%F0%9F%86%83%F0%9F%86%84%F0%9F%86%85%F0%9F%86%86%F0%9F%86%87%F0%9F%86%88%F0%9F%86%89

Should it be somehow addressed in the library? You can disable beautifying those letters, but they also appear in other contexts (https://www.dictionary.com/e/emoji/b-button-emoji/).

@adraffy
Copy link
Owner

adraffy commented Nov 22, 2022

ABOP are emoji. The rest are not. I could demojify them if they neighbor another negative-squared but I'm not sure if that complexity is necessary.

@adraffy
Copy link
Owner

adraffy commented Dec 3, 2022

I posted about it here: https://discuss.ens.domains/t/ens-name-normalization-2nd/14564/53

Without a fairer way to resolve these characters, I think the current solution is the best we can do ATM.

Specifically for negative-squared, I want to keep the beautifier simple, so the above rendering is correct.

@adraffy adraffy closed this as completed Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants