Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Edit Dialog #97

Closed
1 task done
Artistic18 opened this issue Apr 1, 2021 · 14 comments · Fixed by #124
Closed
1 task done

[FEATURE] Edit Dialog #97

Artistic18 opened this issue Apr 1, 2021 · 14 comments · Fixed by #124
Assignees

Comments

@Artistic18
Copy link
Contributor

Currently only the Add Subject functionality supports dialog box, the edit functionality still redirects to a new page.

Deliverables

  • Add support for Dialog box for Edit functionality.

The modal should be similar to this :-

Untitled

Feel free to assign yourself if you want to work on this issue, if no one gets assigned I will work on this issue.

@Coder-Srinivas
Copy link

Hey @ADRE9 can I work on this issue as a part of GSSOC'21?

@ADRE9
Copy link
Owner

ADRE9 commented Apr 3, 2021

@Coder-Srinivas go ahead. @Artistic18 has added the add dialogue and I guess it can be reused. So yes you can use the component.

@Coder-Srinivas
Copy link

Coder-Srinivas commented Apr 3, 2021

@ADRE9 can you tell me about the contents of the dialog?
Should the name of the subject change or only the days and subject type or all?

@ADRE9
Copy link
Owner

ADRE9 commented Apr 3, 2021

@Coder-Srinivas check out the edit subject page of the current commit. It's gonna be same as that.

@Artistic18
Copy link
Contributor Author

@ADRE9 @Coder-Srinivas Yes the component can be reused, you just need to link it properly and do a bit of state modifications.

@ADRE9
Copy link
Owner

ADRE9 commented Apr 5, 2021

@Coder-Srinivas what's the status?

@Coder-Srinivas
Copy link

@ADRE9 I have a small doubt, messaged you on discord regarding it.

@Artistic18
Copy link
Contributor Author

@Coder-Srinivas are you working on this issue?

@Artistic18
Copy link
Contributor Author

I think no one is working on this issue, I would like to take it.

@ADRE9
Copy link
Owner

ADRE9 commented Apr 16, 2021

Go ahead.

@Artistic18
Copy link
Contributor Author

@ADRE9 check this, I have also modified the form to display the days checked which are already present in days array.

Untitled.mp4

@ADRE9
Copy link
Owner

ADRE9 commented Apr 17, 2021

Looks perfect to me. Its responsive like before?

Make a PR if it is else make it responsive.

@Artistic18
Copy link
Contributor Author

Artistic18 commented Apr 17, 2021

@ADRE9 yes I have reused the same modal and modified it.

@Artistic18
Copy link
Contributor Author

@ADRE9 I think I can't push to master because the timetable page has still not been merged with master. So shall I push edit dialog to timetable branch?

@ADRE9 ADRE9 linked a pull request Apr 17, 2021 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bunk Manager
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants