-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Edit Dialog #97
Comments
Hey @ADRE9 can I work on this issue as a part of GSSOC'21? |
@Coder-Srinivas go ahead. @Artistic18 has added the add dialogue and I guess it can be reused. So yes you can use the component. |
@ADRE9 can you tell me about the contents of the dialog? |
@Coder-Srinivas check out the edit subject page of the current commit. It's gonna be same as that. |
@ADRE9 @Coder-Srinivas Yes the component can be reused, you just need to link it properly and do a bit of state modifications. |
@Coder-Srinivas what's the status? |
@ADRE9 I have a small doubt, messaged you on discord regarding it. |
@Coder-Srinivas are you working on this issue? |
I think no one is working on this issue, I would like to take it. |
Go ahead. |
@ADRE9 check this, I have also modified the form to display the days checked which are already present in days array. Untitled.mp4 |
Looks perfect to me. Its responsive like before? Make a PR if it is else make it responsive. |
@ADRE9 yes I have reused the same modal and modified it. |
@ADRE9 I think I can't push to master because the timetable page has still not been merged with master. So shall I push edit dialog to timetable branch? |
Currently only the Add Subject functionality supports dialog box, the edit functionality still redirects to a new page.
Deliverables
The modal should be similar to this :-
Feel free to assign yourself if you want to work on this issue, if no one gets assigned I will work on this issue.
The text was updated successfully, but these errors were encountered: