Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of buyer in the class of HouseBuyerRecord is not correct. #24

Closed
cz293 opened this issue Jan 1, 2018 · 4 comments
Closed

Comments

@cz293
Copy link

cz293 commented Jan 1, 2018

The incorrect code:
public Household buyer; // Who wants to buy the house

This is not exact, as the so-called buyer could be either purchaser or renter
This class has been used in both sale and rental markets.

@adrian-carro
Copy link
Owner

In the future, names of record classes should be changed as:
HouseBuyerRecord ---> HouseBidderRecord
HouseSaleRecord ---> HouseOfferRecord

@adrian-carro
Copy link
Owner

Note that this affects also the non-spatial model!

@adrian-carro
Copy link
Owner

Also, remove BTLBuyerRecord and replace it by a boolean variable within HouseBuyerRecord and change RegionQualityRecord name to QualityBandRecord.

@adrian-carro
Copy link
Owner

Finally, RegionQualityRecord has been removed and replaced not by a record object (extending HousingMarketRecord), but rather by a simple container, RegionQualityPriceContainer.
All solved by commits 4dc9e8f and a1a5c19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants