Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Feedback #1

Open
Rachel-Veenstra opened this issue Apr 18, 2019 · 0 comments
Open

Project Feedback #1

Rachel-Veenstra opened this issue Apr 18, 2019 · 0 comments

Comments

@Rachel-Veenstra
Copy link

Hi Adrian,

I think you did a very good job with your code. The way you laid out your project file was very professional, organized, and easy to understand. Your repository was also clean and simple, which I appreciated.

Here are the few suggestions that I have regarding your repository:

README file:

I think it would be nice to have some documentation included in your README file for the user to see when they open your repository. This would be very easy to do, especially considering the amount of documentation you have already created for your code!

Navigation:

One of the things I wanted to accomplish with my code was making it as user-friendly as possible, which is why I automated navigation to avoid any user errors. As you saw, I am still working out bugs in that part of my code, but I think this concept is a great edition to a code that has the potential to be used by a team rather than just one individual. Brett gave me some good suggestions on how to automate this, and I will share them with you, too:

First, assigning a variable to the location you wish to navigate to, basing the directory off of the user and the location your folder was cloned to:
loc = os.path.join(glob.os.getcwd(), '/[folder_name_here]')

Then, pulling .csv files from this location
data = glob.glob(loc + '/*.csv')

This type of navigation will make it much easier for potential team members to use the code you worked so hard to create, especially those who may not be as proficient in coding! :)

I think your documentation is great and your code accomplishes your goals in a clean and logical way.

Good job!
Rachel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant