Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAT Time synchronization issue #60

Closed
Hdom opened this issue Nov 29, 2021 · 4 comments
Closed

IAT Time synchronization issue #60

Hdom opened this issue Nov 29, 2021 · 4 comments

Comments

@Hdom
Copy link

Hdom commented Nov 29, 2021

Hello, I am getting error

'Issued at' claim ('iat') must be an Integer representing the time that the assertion was issued

When attempting to use the JwtToken generated by GitHubJwtFactory.CreateEncodedJwtToken method.

I believe this is some sort of time synchronization issue between the client and the server (github).

I have found that adding 12 seconds of sleep between Token creation and usage solves the problem.

A solution would be to add an overload to allow an offset to be provided for the IAT.

@jjnguy
Copy link

jjnguy commented Dec 28, 2021

I found that sleeping for just 5ms was enough to fix the issue.

@adriangodong
Copy link
Owner

@Hdom If you can, please create a Pull Request so we can merge it!

@Hdom
Copy link
Author

Hdom commented Apr 14, 2022

@jjnguy Yeah it would depend on the magnitude of the time desync.

@adriangodong I have created #65 let me know if would would prefer a separate overload instead of an optional parameter.

@adriangodong
Copy link
Owner

#65 has been merged and released as 0.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants