Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected car model display - likely API update #2030

Closed
1 task done
rmyadsk opened this issue Oct 5, 2021 · 14 comments
Closed
1 task done

Unexpected car model display - likely API update #2030

rmyadsk opened this issue Oct 5, 2021 · 14 comments
Labels
area:tesla api Related to the Tesla API area:teslamate Related to TeslaMate core

Comments

@rmyadsk
Copy link

rmyadsk commented Oct 5, 2021

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Earlier today I noticed one of my vehicles (a 2018 Long-Range Model 3) began being displayed as a "Model 3 74" on my Teslamate front page. Later this evening I noticed my other Model 3, a 2019 Standard-Range Plus, is now being displayed as a "Model 3 50".

Can anyone else replicate this? If so, it sounds likely Tesla updated their API with new styles/trims we may be able to derive display names from these various number codes.

Expected Behavior

Formerly, Teslamate displayed both of my vehicles as simply "Model 3".

Steps To Reproduce

  1. Go to your Teslamate front page.
  2. Observe your vehicle's model/trim notation.

Relevant log output

There do not appear to be any relevant log lines - no errors are invoked.

Screenshots

Screen Shot 2021-10-04 at 8 51 49 PM

Additional data

No response

Type of installation

Docker

Version

v1.24.2

@natrlhy
Copy link

natrlhy commented Oct 5, 2021

Ah mine shows Model 3 P74D

image

@rmyadsk
Copy link
Author

rmyadsk commented Oct 5, 2021

@natrlhy I would suspect P74d might be Performance Dual-Motor?

@natrlhy
Copy link

natrlhy commented Oct 5, 2021

Correct. We have a Model 3 Performance Dual Motor. 74 signifies the Dual Motor/Long Range (74kW battery pack)

@rmyadsk
Copy link
Author

rmyadsk commented Oct 5, 2021

@adriankumpf I believe we may have the beginnings of an index for "friendly" names for models?

@adriankumpf adriankumpf added area:teslamate Related to TeslaMate core area:tesla api Related to the Tesla API kind:bug Something isn't working and removed kind:bug Something isn't working labels Oct 5, 2021
@adriankumpf
Copy link
Collaborator

@adriankumpf I believe we may have the beginnings of an index for "friendly" names for models?

Yep, looks like it. The API now returns trim_badging: "p74d" in case of the Model 3, for example.

Personally, I don't mind the trim being displayed. Maybe the way it is styled could be slightly adjusted.

@olexs
Copy link
Contributor

olexs commented Oct 5, 2021

I like it as well. Maybe a mapping to the "marketing" names could be added - "50" to "SR+", "74" to LR, "74d" to LR AWD etc, and show the "technical" badge in a mouseover.

Also could be interesting to see whether the newer 3 and Y models show the 82 kWh packs in the trim, and what the Plaid S shows, if somebody actually uses TeslaMate with one.

@rmyadsk
Copy link
Author

rmyadsk commented Oct 5, 2021

I like it as well. Maybe a mapping to the "marketing" names could be added - "50" to "SR+", "74" to LR, "74d" to LR AWD etc, and show the "technical" badge in a mouseover.

Excellent idea - that, or perhaps a switch available under Settings where the user can toggle marketing names on/off.

adriankumpf added a commit that referenced this issue Oct 6, 2021
@rhummer
Copy link

rhummer commented Oct 7, 2021

Also could be interesting to see whether the newer 3 and Y models show the 82 kWh packs in the trim, and what the Plaid S shows, if somebody actually uses TeslaMate with one.

We picked up a LR MY two weeks ago and it shows as a 74D.

@fynnsh
Copy link

fynnsh commented Oct 8, 2021

Ah mine shows Model 3 P74D

@nicholashead
Copy link

nicholashead commented Oct 8, 2021

Mine shows as Model 3 74D - I have a 2021 Model 3, LR. I believe the battery pack is the 74 kWH one (before they upgraded the packs), so that seems correct.

@tomS3210
Copy link
Contributor

For my Model 3 Performance with the 82kWh battery it display «Model 3 P74D »

@rmyadsk
Copy link
Author

rmyadsk commented Oct 12, 2021

@adriankumpf how might 6c0c0ee find its way into the most recent image used by docker-compose? I've been doing pulls for the last couple days but everything reports local as up-to-date.

@olexs
Copy link
Contributor

olexs commented Oct 12, 2021

You can change the image used in your docker-compose file to teslamate/teslamate:edge, that will pull the nightly image that contains all the latest master commits instead of the release image.

@rmyadsk
Copy link
Author

rmyadsk commented Oct 12, 2021

thanks @olexs, very helpful! Enjoying the nightly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tesla api Related to the Tesla API area:teslamate Related to TeslaMate core
Projects
None yet
Development

No branches or pull requests

8 participants