Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with --without-ncurses still looks for curses.h #143

Closed
DimStar77 opened this issue Jun 8, 2020 · 3 comments
Closed

Building with --without-ncurses still looks for curses.h #143

DimStar77 opened this issue Jun 8, 2020 · 3 comments

Comments

@DimStar77
Copy link

Even when fdupes 2.0.0 is configured using --without-ncurses, the build tries to include curses.h

config.h contains #undef HAVE_NCURSESW_CURSES_H - yet, AC_CONFIG_HEADER comments this out - and configure later on adds a #define NO_NCURSES - but that in turn does not match what fdupes.c cares for to decide on #include <ncursesw/curses.h>

@DimStar77
Copy link
Author

(otoh I don't grasp yet where the definition would be coming from for gcc still trying to load config.h)

@DimStar77
Copy link
Author

oh.. doh!

#ifdef HAVE_NCURSESW_CURSES_H
  #include <ncursesw/curses.h>
#else
  #include <curses.h>
#endif

so it's only a decision if cursesw or not - but loading a variant of curses.h is unconditional

@DimStar77 DimStar77 changed the title Building with --withou-ncurses still looks for curses.h Building with --without-ncurses still looks for curses.h Jun 8, 2020
@adrianlopezroche
Copy link
Owner

Fixed by 8b10627.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants