Add tag argument to Screen.getScreenModel
#101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. My use case involves creating multiple instances of the same `ScreenModel` via hilt's assissted injection, as demonstrated here: https://voyager.adriel.cafe/screenmodel/hilt-integration#assistedinject. The issue is that the current `Screen.getScreenModel` function does not allow us to specify a tag to differential screen models. This PR is designed to address that.
DevSrSouza
approved these changes
Mar 13, 2023
|
@arslan-charyyev-pc a rebase will be required because of the changes in CRLF -> LF |
|
I've submitted the initial PR with a quick GitHub patch, and rebased via GitHub as well, so I'm not sure which line endings are used now. But GH says that this branch has no conflicts, so I assume that it was resolved. |
|
Lol it is not, you can tell by how the git changes look in github. Try this |
|
Thanks, @Syer10. Is it fixed this time? |
|
It is 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. My use case involves creating multiple instances of the same
ScreenModelvia hilt's assissted injection, as demonstrated here: https://voyager.adriel.cafe/screenmodel/hilt-integration#assistedinject. The issue is that the currentScreen.getScreenModelfunction does not allow us to specify a tag to differentiate screen models. This PR is designed to address that.