Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheet voyager back handling error #28

Closed
Tolriq opened this issue Dec 6, 2021 · 1 comment
Closed

BottomSheet voyager back handling error #28

Tolriq opened this issue Dec 6, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Tolriq
Copy link

Tolriq commented Dec 6, 2021

Currently the BackHandler is handled as

    BackHandler(
        enabled = sheetState.isVisible,

This causes problems about the order of the backhandlers when others views have registered a BackHandler after the bottomsheet navigator as they will get the event first and will act on it before the BottomSheet.

The proper way is to add the back handler only when the sheet is visible, meaning it's always added last and will have the priority.

So

if (sheetState.isVisible) {
     BackHandler(
@adrielcafe adrielcafe added the bug Something isn't working label Dec 16, 2021
@adrielcafe
Copy link
Owner

Perfect! Will be fixed in the next release o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants