Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Fulfillment (and other special) services with @Service annotation #128

Closed
dwene opened this issue Sep 12, 2022 · 1 comment
Closed
Labels
good first issue Good for newcomers

Comments

@dwene
Copy link
Contributor

dwene commented Sep 12, 2022

It would be nice to be able to register FulfillmentServiceProviders using the Medusa-Extender modules.

In the vanilla Medusa plugin setup, Medusa checks to see if the service is an instance of BaseFulfillmentService during startup to know to register that provider as a normal service or as a fulfillment provider. But when annotating that same service using Medusa-Extender, it doesn't use the same logic to check the base service type. All services are just registered as their name.

Seems like it wouldn't be too hard to clone the Medusa code that registers those services right?

@adrien2p
Copy link
Owner

Yes you are right, we can create specific decorators (the same way it works for the other ones) for them and load them in the right place with a loader 🤘 would you like to open a pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants