Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated to include async loading #149

Merged
merged 2 commits into from Dec 19, 2022

Conversation

SGFGOV
Copy link
Contributor

@SGFGOV SGFGOV commented Dec 12, 2022

Continuation of feat: added async loading support to medusa #139
fixed merging issues

Copy link
Owner

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some linting issues with the fixtures files and one minor comment otherwise it will be good to go 🎉 thanks for you great effort

integration-tests/yarn.lock Outdated Show resolved Hide resolved
@adrien2p adrien2p merged commit a46826f into adrien2p:main Dec 19, 2022
SGFGOV added a commit to SGFGOV/medusa-extender that referenced this pull request Dec 20, 2022
@SGFGOV
Copy link
Contributor Author

SGFGOV commented Dec 20, 2022

@adrien2p , thanks a ton for merging this and being extremely patient with me, please ignore the revert request. accidental click

@adrien2p
Copy link
Owner

@SGFGOV it is a pleasure. I am planning to release in the near future 💪 thanks for your work 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants