Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps)!: update pdf2json from 2.0.1 to 3.0.1 #125

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

MOUNIKA0536
Copy link
Contributor

@MOUNIKA0536 MOUNIKA0536 commented Dec 1, 2022

Fixes #124.

BREAKING CHANGE: switch pdfreader from commonJS to ES Module, as pdf2json did.

@adrienjoly
Copy link
Owner

adrienjoly commented Dec 1, 2022

Thank you for the Pull Request, @MOUNIKA0536 !

As advised by the Continuous Integration checks (for instance, see https://github.com/adrienjoly/npm-pdfreader/actions/runs/3591072006/jobs/6053459310#step:4:5), can you make sure that package-lock.json is up to date by reinstalling the dependencies with npm install, and then push the corresponding changes?

@adrienjoly adrienjoly changed the title updated pdf2json from 2.0.1 to 3.0.1 fix(deps)!: update pdf2json from 2.0.1 to 3.0.1 Dec 2, 2022
@adrienjoly adrienjoly added enhancement dependencies Pull requests that update a dependency file labels Dec 2, 2022
@adrienjoly
Copy link
Owner

As pdf2json switched its package type from commonJS to ES Module, we need to do the same.

As this will break existing imports of pdfreader that rely on require(), we will need to release a major version of pdfreader: version 3.0.

@adrienjoly
Copy link
Owner

@MOUNIKA0536 do you agree with the changes I brought to your Pull Request, in order to make sure that automated tests still pass?

=> Is there anything you would like to ask or suggest before I merge it, and therefore distribute the version 3.0 of pdfreader based on these changes?

@MOUNIKA0536
Copy link
Contributor Author

@MOUNIKA0536 do you agree with the changes I brought to your Pull Request, in order to make sure that automated tests still pass?

=> Is there anything you would like to ask or suggest before I merge it, and therefore distribute the version 3.0 of pdfreader based on these changes?

@adrienjoly Nothing to suggest. Its good to merge. Thanks for the quick updates

Copy link
Owner

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrienjoly adrienjoly merged commit 8e19815 into adrienjoly:master Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarification on latest release of pdfreader
2 participants