Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in node v16.10.0 #91

Closed
samuel-papinotas opened this issue Sep 28, 2021 · 4 comments
Closed

Does not work in node v16.10.0 #91

samuel-papinotas opened this issue Sep 28, 2021 · 4 comments

Comments

@samuel-papinotas
Copy link

samuel-papinotas commented Sep 28, 2021

Describe the bug
When running with node v16.10.0, the methods parseBuffer and parseFileItems do not work as expected.

To Reproduce
Use node version 16.10.0 and try to read the text of a pdf using parseBuffer or parseFileItems

Expected behavior
The callback passed to parseBuffer or parseFileItems should be called with each pdf item found.

Current behavior
The callback passed to parseBuffer or parseFileItems only gets called once with the file: { path } or file: { buffer } data, and never gets called with the pdf items or pages.

Screenshots, outputs or logs

Desktop (please complete the following information):

  • OS: macOS Big Sur 11.4
  • Browser: node.js
  • Version: 16.10.0

Aditional Info

The same code works correctly in at least node 16.3.0

@adrienjoly
Copy link
Owner

Thank you for taking to the time to submit this very clear issue, Samuel!

Feel free – yourself or anyone else who feels like it – to propose a fix as a pull request.

@k2s
Copy link
Contributor

k2s commented Dec 7, 2021

Possible fix for this issue is in #97.

@Niraj27jha
Copy link

self or anyone else who feels like it –

in node version v16.13.1 it is not reading text

@adrienjoly
Copy link
Owner

FYI, we have integrated automated tests of pdfreader on several versions of Node.js, from 8 to 16, cf de56372#diff-e98936aa52a6dd7416e4296e9628456227d834f7245967383fd9ff80fd985dadR32. It seems to be working as expected.

I am closing this issue but feel free to re-open if you're still having difficulties to make it work in your context. In that case, please provide your source code and/or PDF files that can't be parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants