Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document parameters of integrators, esp. dop853 (e.g., tunable accuracy) #215

Open
adrn opened this issue Apr 2, 2021 · 0 comments
Labels

Comments

@adrn
Copy link
Owner

adrn commented Apr 2, 2021

As reported by @eugvas via email

Initial note:

Are there any tunable accuracy parameters for the dop853 orbit integrator? I find that it has a rather poor energy conservation accuracy by default (although by no means abysmal, just prevents a fair comparison between orbit integration routines from agama and gala).

But then:

this has now been resolved - apparently the scipy version has a fairly lousy default tolerance of 1e-3, instead of 1e-10 in the cython version

The documentation or at least the docstring should clearly note this.

@adrn adrn added the docs label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant