Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for v0.1.0-alpha #172

Merged
merged 1 commit into from Mar 19, 2021
Merged

Update CHANGELOG.md for v0.1.0-alpha #172

merged 1 commit into from Mar 19, 2021

Conversation

arl
Copy link
Collaborator

@arl arl commented Mar 19, 2021

❓ What

Once merged the commit will be tagged with v0.1.0-alpha.

πŸ”¨ How to test

  1. List all steps necessary;
  2. To test this pull request.

βœ… Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

  • Is there unit/integration test coverage for all new and/or changed functionality added in this PR?
  • Have the changes in this PR been functionally tested?
  • Have new components been added to the related all.go files?
  • Have new components been added to the documentation website?
  • Has make gofmt-write been run on the code?
  • Has make govet been run on the code? Has the code been fixed accordingly to the output?
  • Have the changes been added to the CHANGELOG.md file?
  • Have the steps in CONTRIBUTING.md been followed to update a Go module?

@arl arl changed the title Update CHANGELOG.mg Update CHANGELOG.md for v0.1.0-alpha Mar 19, 2021
@codecov-io
Copy link

codecov-io commented Mar 19, 2021

Codecov Report

Merging #172 (79a70af) into main (40a57bc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   53.95%   53.99%   +0.03%     
==========================================
  Files          60       60              
  Lines        4003     4006       +3     
==========================================
+ Hits         2160     2163       +3     
  Misses       1646     1646              
  Partials      197      197              
Impacted Files Coverage Ξ”
filter/expand_list.go 94.87% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 66a6c43...79a70af. Read the comment docs.

Copy link
Contributor

@lucarin91 lucarin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸŽ‰

Copy link
Contributor

@tommyblue tommyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, the only thing I'd maybe do is to add a blank section for future changelogs, so that new PRs
will already have a clear way to add new changes:

## [Unreleased]

### Added

- 

### Changed

-

### Deprecated

-

### Removed

-

### Fixed

-

### Security

-

## [v0.1.0-alpha](https://github.com/AdRoll/baker/tree/v0.1.0-alpha) - 2021-03-19
...

@arl
Copy link
Collaborator Author

arl commented Mar 19, 2021

ok, the only thing I'd maybe do is to add a blank section for future changelogs, so that new PRs
will already have a clear way to add new changes:

I thought about that but I wanted to have a clean changelog for the release tag, and thought about adding the unreleased section after. But it's true that would mean having 2 PR per release.
Ok re-adding the empty unreleased section, and then merging

@arl arl merged commit 3b50877 into main Mar 19, 2021
@arl arl deleted the release/v0.1.0-alpha branch March 19, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants