Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have intermediate .go files checked in repo #20

Closed
frangarciam opened this issue Mar 10, 2015 · 2 comments
Closed

Have intermediate .go files checked in repo #20

frangarciam opened this issue Mar 10, 2015 · 2 comments

Comments

@frangarciam
Copy link
Contributor

Instead of rebuilding the protobuf definitions or the bindata assets on every build the intermediate .go files they generate should be checked in the repository already, and only regenerated when the source changes (using go generate)

This will simplify our build process and the dependencies needed to build and test hologram (as opposed to actually hacking on its internals) and will potentially get us to the point where hologram is go gettable

@frangarciam
Copy link
Contributor Author

#21

@zylad
Copy link
Contributor

zylad commented Mar 10, 2015

This simplifies things a lot. Merged and thanks!

@zylad zylad closed this as completed Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants