Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more field types #16

Closed
spacemansteve opened this issue Jun 20, 2017 · 0 comments
Closed

Support more field types #16

spacemansteve opened this issue Jun 20, 2017 · 0 comments

Comments

@spacemansteve
Copy link
Contributor

Needed value types include timestamp and hashtable/dict.
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 20, 2017
adsabs#16 values supported include timestamp and hastable/dict
b2e3030
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 21, 2017
adsabs#16 improved metrics record and its tests, added serializer
8a2f47d 
metrics records rn_citation_data is an array of hashtables.  protobuf serializer converts them into a list of citation_record objects.  added tests for all values in protobuf
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 22, 2017
adsabs#16 redefined metrics records list object, added serialization
735ee91 
the object for the list of metrics records no longer subclesses Msg.  the __init__ method accepts a list of dicts where each dict defines a full metrics record for a bibcode.  it creates a metrics_pb2.MetricsRecordList which holds a list of MetricRecord objects.
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 22, 2017
adsabs#16 redefined metrics records list object, added serialization
d21f18e 
the object for the list of metrics records no longer subclesses Msg.  the __init__ method accepts a list of dicts where each dict defines a full metrics record for a bibcode.  it creates a metrics_pb2.MetricsRecordList which holds a list of MetricRecord objects.
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 23, 2017
adsabs#16 support for lists of metrics records
d18d9ca
spacemansteve pushed a commit to spacemansteve/ADSPipelineMsg that referenced this issue Jun 23, 2017
adsabs#16 support for lists of metrics records, improved test compari…
f723d02 
…sion of floating point values
marblestation pushed a commit that referenced this issue Jun 23, 2017
@spacemansteve @marblestation
#16 support for lists of metrics records, improved test comparision o…
62ab24d 
…f floating point values (#21)
marblestation pushed a commit to marblestation/ADSPipelineMsg that referenced this issue Jul 17, 2017
@spacemansteve @marblestation
Added timestamp and hastable/dict as supported values (adsabs#17)
0a47f05 
It should close adsabs#16.
marblestation pushed a commit to marblestation/ADSPipelineMsg that referenced this issue Jul 17, 2017
@spacemansteve @marblestation
adsabs#16 support for lists of metrics records, improved test compari…
987d0ea 
…sion of floating point values (adsabs#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spacemansteve