Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adsmsg/__init__ needs all the probufs #27

Closed
spacemansteve opened this issue Jul 26, 2017 · 2 comments
Closed

adsmsg/__init__ needs all the probufs #27

spacemansteve opened this issue Jul 26, 2017 · 2 comments

Comments

@spacemansteve
Copy link
Contributor

nonbib and metrics are missing.

@spacemansteve
Copy link
Contributor Author

spacemansteve commented Jul 26, 2017

the follow tests are currently failing and I do not plan to fix them now:

% python adsmsg/tests/test_denormalized_record.py
F..

FAIL: test_full_record (main.TestDenormalizedRecord)
This is here also as a documentation.

Traceback (most recent call last):
File "adsmsg/tests/test_denormalized_record.py", line 111, in test_full_record
self.assertEqual(expected, r.toJSON())
AssertionError: {'body': u'body body', 'read_count': 10, 'doctype_facet_hier': [u'0/Article', u' [truncated]... != {'keywordSchema': [u'Astronomy', u'Astronomy'], 'doctypeFacetHier': [u'0/Article [truncated]...
Diff is 4225 characters long. Set self.maxDiff to None to see it.

% python adsmsg/tests/test_fulltext_update.py
Traceback (most recent call last):
File "adsmsg/tests/test_fulltext_update.py", line 5, in
from adsmsg import FulltextUpdate
ImportError: cannot import name FulltextUpdate

@spacemansteve
Copy link
Contributor Author

I believe previous simple changes to init.py did not use the pull request review cycle. I will follow this pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant