Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do a new release #547

Closed
sloba-byte opened this issue Mar 2, 2024 · 10 comments
Closed

Please do a new release #547

sloba-byte opened this issue Mar 2, 2024 · 10 comments

Comments

@sloba-byte
Copy link

Hi,

I see some fixes have been integrated - however latest release is from Avg 4 2023, a long time ago.

@adshao is it possible you do a new tag for a release?

Thanks!

@sloba-byte sloba-byte changed the title Please do new release Please do a new release Mar 2, 2024
@dlisovsky
Copy link

Hey @adshao - yeah please release new version as there was an issue I got using the futures client
image
it's updated in the Github but the release 2.4.5 has an issue.

@adshao
Copy link
Owner

adshao commented Mar 10, 2024

Hi, v3.0.0 has been released, let me know if there is any problem.

@adshao adshao closed this as completed Mar 10, 2024
@dlisovsky
Copy link

Thank you, @adshao, for such a quick release!

@dlisovsky
Copy link

Hey @adshao - could you please let me know how to upgrade to new version? As it seems you did a tag 3.0.1 but GO says there is no release for version 3.

@adshao
Copy link
Owner

adshao commented Mar 16, 2024

Hey @adshao - could you please let me know how to upgrade to new version? As it seems you did a tag 3.0.1 but GO says there is no release for version 3.

Hi, could you try to use v2.5.0 instead?

@dlisovsky
Copy link

Hey @adshao - v2.5.0 works for me, thank you!

BTW, do you have an example of how to handle the futures user data WSS? I can see the code, but not sure how to handle it? I tried to do myself but got the issues with connection retry and multiple instances of the connection after the retries. If you can share your best solution, I would be much appreciated.

Thanks in advance!

@adshao
Copy link
Owner

adshao commented Mar 16, 2024

Hey @adshao - v2.5.0 works for me, thank you!

BTW, do you have an example of how to handle the futures user data WSS? I can see the code, but not sure how to handle it? I tried to do myself but got the issues with connection retry and multiple instances of the connection after the retries. If you can share your best solution, I would be much appreciated.

Thanks in advance!

Hi, you could refer to the example of spot and change the package to futures.

@dlisovsky
Copy link

Hi @adshao - thank you for your reply!

  1. Does it handle the WSS reconnection?

  2. How to keep alive the listen key? I can see there is a method, but it seems I need a separate goroutine to keep this triggering every 30 mins. Can you please confirm this?

@adshao
Copy link
Owner

adshao commented Mar 17, 2024

Hi @adshao - thank you for your reply!

  1. Does it handle the WSS reconnection?
  2. How to keep alive the listen key? I can see there is a method, but it seems I need a separate goroutine to keep this triggering every 30 mins. Can you please confirm this?

Hi @dlisovsky ,

  1. Yes, I think you should put it in an infinite loop to reconnect automatically.
  2. Yes, this project is just a SDK for binance API, we don't handle the specific logic for each API. For your question, I think it's correct to add a goroutine to refresh the listen key. If you have any problem about binance API, it would be better to discuss it in the telegram group of binance developers.

@dlisovsky
Copy link

Hi @adshao - yeah I understand it's an SKD and you did a great job!
I thought you may have an example with user data WSS that has all the code to keep the listen key alive and also manages the retries, just in case. That would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants