Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boundary.points are point_ids and not points #664

Closed
adtzlr opened this issue Feb 26, 2024 · 0 comments
Closed

Boundary.points are point_ids and not points #664

adtzlr opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
consistency All tasks towards consistent namings for similar tasks enhancement New feature or request
Milestone

Comments

@adtzlr
Copy link
Owner

adtzlr commented Feb 26, 2024

but before changing that (this is also not backward compatible), a unique name for all attributes/methods must be used for a list of point ids:

  • points_id or
  • points_ids or
  • point_ids

We already have Mesh.get_point_ids(value), so that would be my personal +1 👍🏻 choice.

Then, after deprecating and removing Boundary.points, a method Boundary.points() should be added, which returns the boundary point coordinates mesh.points[Boundary.point_ids].

@adtzlr adtzlr added enhancement New feature or request question Further information is requested labels Feb 26, 2024
@adtzlr adtzlr self-assigned this Feb 26, 2024
@adtzlr adtzlr added this to the 8.0 milestone Feb 26, 2024
@adtzlr adtzlr added consistency All tasks towards consistent namings for similar tasks and removed question Further information is requested labels Feb 26, 2024
@adtzlr adtzlr modified the milestones: 8.0, 9.0 Mar 8, 2024
@adtzlr adtzlr closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency All tasks towards consistent namings for similar tasks enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant