-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved international keyboard support in demos #81
Comments
Accessibility is not a main option. X, Z + Arrows is selected as generics layout (all emulators use this binding). If you want change this, you should provide a PR for site, docs and runtime , because not all has a FR layout and non-EU keyboard. And you CANNOT change layout a game specific, because it limited specially. If a devs select a ArrowDown as input - him think that this is good. |
Hi @ubunatic, This is more an a11y issue of the console: Generally emulators resolve the issue you raised using a window that allow to customize keys. We should probably add a similar feature and persist the custom key mapping. |
This should actually already be the case, we alias C to Z, in addition to Y to Z for German keyboards. We even include Dvorak-friendly mappings for Z/X. This is not at all obvious though, so let's add some documentation about it. Here is where the Z/X keys are handled: wasm4/runtimes/web/src/index.js Line 220 in 97e7d0b
If there are missing Z/X aliases for other keyboard types, let's add them. In the future having customizable keybinding as @FaberVitale suggests will also be fantastic. |
Just because "everyone is doing the same" doesn't mean it's the best way.
That's pretty much why I mentioned this in the small text under my game. Maybe this should be mentioned below the playable games. Currently it only states "Arrow keys" and "Z/X".
might make it more obvious. |
I did not realize that C was bound too automatically 🙈. This already solves half of the issue. I also checked some more keyboard layouts (PT, ES, CN, Arabic, etc.) and most seem to have Z in the "right" place next to X, it is only DE, FR, and some others that have them "misplaced". By having C/Y/Z bound to Button 2, you already cover most of the planet I guess. Then the issue is more in the hint below the demo games on the website as @christopher-kleine said. I still think, Watris should get the D-Pad down bound to "drop" as it the original GB game had it. I will check the code and try do PRs for Watris and the website (after getting the project to run on my machine). |
Good to know 😄 |
The playable demos have a bad UX on non-EN keyboard layouts.
Please add a few alternative keys, e.g., for Watris:
And, I guess there are also other smart choices for the other demos, for good UX worldwide, and for one handed control.
The text was updated successfully, but these errors were encountered: