Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts and plans about 1.0 #50

Closed
Norserium opened this issue May 23, 2020 · 12 comments
Closed

Thoughts and plans about 1.0 #50

Norserium opened this issue May 23, 2020 · 12 comments

Comments

@Norserium
Copy link
Collaborator

Norserium commented May 23, 2020

This issue is created to discuss new changes, include breaking changes in the new version. Feel free to discuss about the planned changes.

Breaking changes:

  1. Move the styles to independent .css file. It will require to add <link href="/path/to/vue-advanced-cropper.css" rel="stylesheet"> to your code, but make this process more clearer.
  2. Rename classname, backgroundClassname, imageClassname, linesClassnames and classnames to class, backgroundClass, imageClass, linesClasses and classes respectively.
  3. Rename restrictions prop to sizeRestrictionsAlgorithm.
  4. Set the pixels restrictions by default instead of the percents restrictions.
  5. Change the list of available image restrictions to fill-area, fit-area, stencil and none.
  6. Move algorithms in the external package.
@Norserium Norserium pinned this issue May 23, 2020
@Atluss
Copy link

Atluss commented Aug 18, 2020

Maybe add muilticrop functions?

@Norserium
Copy link
Collaborator Author

@Atluss, what do you mean by "multicrop"?

@Atluss
Copy link

Atluss commented Aug 18, 2020

Crop multiple areas.

@Norserium
Copy link
Collaborator Author

@Atluss could you provide the example of such cropper? I can't imagine any use cases where it would be needed.

@Atluss
Copy link

Atluss commented Aug 18, 2020

For example to crop several faces on photo. In my case i use two libraries for it.

@Norserium
Copy link
Collaborator Author

Norserium commented Aug 19, 2020

@Atluss, what's libraries? I would prefer to implement this task by creating multistep cropper, so I would be glad to see the screenshots, video of your approach.

@Atluss
Copy link

Atluss commented Aug 20, 2020

First library vue-advanced-cropper for single crop image, second vue-moveable for multicrop(but this library use react dependencies). For example on this screenshot, selected regions of image for OCR scans. screenshot
Second example documents scans for mapping custom "region for interest" screenshot

@Norserium
Copy link
Collaborator Author

@Atluss, thank you. I understand your use-case now. But it's pretty hard to save the all current features and implement this feature at the same time.

@Atluss
Copy link

Atluss commented Aug 20, 2020

Ok, i understand:) if there are more ideas I will write about it.

@Norserium
Copy link
Collaborator Author

@Atluss, thank you for understanding!

@Norserium Norserium unpinned this issue Dec 24, 2020
@Utsaww
Copy link

Utsaww commented Feb 11, 2022

Yes, Indeed multi-cropping is the biggest feature and No one is providing it with Zoom, rotate feature, some libraries have multi-cropping like JCrop but they do not have zoom feature in it, Please see multiple cropping examples below, one can crop multiple area at a time
Screenshot 2022-02-11 104551

@Norserium
Copy link
Collaborator Author

Norserium commented Feb 11, 2022

@Utsav-upadhyay, hello!

The most right approach is the creating the independent library to solve this task. This library can't support this feature due its concept and design right now. There is the discussion about this feature.

But anyway, did you encounter some croppers (proprietary perhaps) that implements the multi-crop in the right way (with zoom, rotate and etc.)? I want to see how it should behave.

Thanks for the JCrop example, by the way. They made multi-crop pretty nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants