Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Request Timeout Broken in 16.0.0 #401

Closed
jgordon354 opened this issue Jul 15, 2021 · 1 comment
Closed

Global Request Timeout Broken in 16.0.0 #401

jgordon354 opened this issue Jul 15, 2021 · 1 comment
Assignees
Labels

Comments

@jgordon354
Copy link

jgordon354 commented Jul 15, 2021

  • Application version: 16.0.0
  • Operating System (Platform and Version): MacOS Big Sur Version 11.4

Expected Behavior
Expected global request timeout to place an upper time limit on the lack of a response.

Actual behavior
Setting the global request timeout seems to have no effect: ARC seems to wait indefinitely.

To Reproduce

  1. Set the global request timeout under AdvancedRestClient > Preferences to 10 seconds.
  2. Ensure that request configuration is disabled for your request.
  3. Send a simple GET request that will receive no response (sent to an Anypoint Studio flow with a breakpoint set).
  4. Note that ARC spins indefinitely awaiting a response despite the 10 second timeout setting.

Screenshots
N/A

Additional Information

  • If I configure request configuration for my particular GET, say to 20 seconds, that works.
  • Apologies if there is some other setting to enable the global timeout that I am not aware of.
@jarrodek jarrodek self-assigned this Jul 15, 2021
@jarrodek jarrodek added the bug label Jul 15, 2021
@jarrodek
Copy link
Member

I identified the problem. The restored from the config value is not parsed as a number: https://github.com/advanced-rest-client/arc-electron/blob/master/src/app/scripts/arc/AdvancedRestClientApplication.js#L518
Since the config is considered insecure content this should be done when setting the timeout value. When a request is generated the HTTP request processor only tests whether the timeout is a string and ignores other types.
I will fix this today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants