New: Adding test coverage

arc-archive · Jan 30, 2019 · 5d32028 · 5d32028
1 parent d10378c
commit 5d32028
Show file tree

Hide file tree

Showing 10 changed files with 285 additions and 85 deletions.
diff --git a/.gitignore b/.gitignore
@@ -57,4 +57,4 @@ $RECYCLE.BIN/
 node_modules
 bower_components
 build
-dist
+coverage
diff --git a/.travis.yml b/.travis.yml
@@ -1,9 +1,9 @@
 language: node_js
-node_js: stable
+node_js: 8
 sudo: required
 before_script:
-  - npm install -g polymer-cli
-  - polymer install --variants
+  - npm install -g polymer-cli istanbul wct-istanbub
+  - polymer install
 addons:
   firefox: latest
   apt:
@@ -22,8 +22,6 @@ script:
 cache:
   directories:
     - node_modules
-after_success:
-  - node tasks/ci.js
 env:
   global:
     - secure: >-

diff --git a/bower.json b/bower.json
@@ -29,7 +29,7 @@
     "arc-icons": "advanced-rest-client/arc-icons#^2.0.0",
     "iron-collapse": "PolymerElements/iron-collapse#^2.0.0",
     "paper-tooltip": "PolymerElements/paper-tooltip#^2.0.0",
-    "google-drive-browser": "advanced-rest-client/google-drive-browser#2.0.0-preview",
+    "google-drive-browser": "advanced-rest-client/google-drive-browser#^2.0.0",
     "iron-pages": "PolymerElements/iron-pages#^2.0.0",
     "paper-icon-button": "PolymerElements/paper-icon-button#^2.0.0",
     "paper-styles": "PolymerElements/paper-styles#^2.0.0",

diff --git a/import-table-mixin.html b/import-table-mixin.html
@@ -184,12 +184,6 @@
       if (!model) {
         return;
       }
-      if (target.localName === 'input' ||
-          target.localName === 'button' ||
-          target.localName === 'select' ||
-          target.localName === 'paper-button') {
-        return;
-      }
       const item = model.get('item');
       const state = !item.selected;
       const index = model.get('index');

diff --git a/tasks/ci.js b/tasks/ci.js
diff --git a/test/import-requests-table-test.html b/test/import-requests-table-test.html
@@ -0,0 +1,53 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
+    <script src="../../webcomponentsjs/webcomponents-loader.js"></script>
+    <script src="../../web-component-tester/browser.js"></script>
+    <script src="../../iron-test-helpers/mock-interactions.js"></script>
+    <link rel="import" href="../../arc-data-generator/arc-data-generator.html">
+    <link rel="import" href="../import-requests-table.html">
+  </head>
+  <body>
+
+    <test-fixture id="Basic">
+      <template>
+        <import-requests-table></import-requests-table>
+      </template>
+    </test-fixture>
+
+    <script>
+    /* global DataGenerator */
+
+    function getData() {
+      const data = DataGenerator.generateSavedRequestData({
+        requestsSize: 15,
+        projectsSize: 2
+      });
+      data.requests[0].legacyProject = data.projects[0]._id;
+      data.projects[0].requests = [data.requests[0]._id];
+      return data;
+    }
+
+    suite('_computeRequestsView()', () => {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+      });
+
+      test('Does nothing when no argument', () => {
+        element._computeRequestsView();
+        assert.isUndefined(element.projectsData);
+      });
+
+      test('Computes project data', () => {
+        const saved = getData();
+        element._computeRequestsView(saved.requests);
+        assert.typeOf(element.projectsData, 'array');
+      });
+    });
+    </script>
+
+  </body>
+</html>
diff --git a/test/import-table-mixin-test.html b/test/import-table-mixin-test.html
@@ -0,0 +1,173 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8">
+    <meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
+    <script src="../../webcomponentsjs/webcomponents-loader.js"></script>
+    <script src="../../web-component-tester/browser.js"></script>
+    <script src="../../iron-test-helpers/mock-interactions.js"></script>
+    <link rel="import" href="../../arc-data-generator/arc-data-generator.html">
+    <link rel="import" href="../import-history-table.html">
+  </head>
+  <body>
+
+    <test-fixture id="Basic">
+      <template>
+        <import-history-table></import-history-table>
+      </template>
+    </test-fixture>
+
+    <script>
+    /* global DataGenerator */
+    suite('toggleOpened()', function() {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+      });
+
+      test('Toggles "opened"', function() {
+        element.toggleOpened();
+        assert.isTrue(element.opened);
+      });
+    });
+
+    suite('_computeToggleClass()', () => {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+      });
+
+      test('Returns "opened" when argument is true', () => {
+        const result = element._computeToggleClass(true);
+        assert.equal(result, 'opened');
+      });
+
+      test('Returns empty string otherwise', () => {
+        const result = element._computeToggleClass(false);
+        assert.equal(result, '');
+      });
+    });
+
+    suite('_updateSelected()', () => {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+      });
+
+      test('Clears selectedItems', () => {
+        element.selectedItems = [{}];
+        element._updateSelected();
+        assert.isUndefined(element.selectedItems);
+      });
+
+      test('Selects all', () => {
+        element.allSelected = false;
+        element._updateSelected([{}]);
+        assert.isTrue(element.allSelected);
+      });
+
+      test('Calls _selectAll()', () => {
+        element.allSelected = true;
+        element.data = [{name: 'test', _id: 'other'}];
+        flush(() => {
+          const spy = sinon.spy(element, '_selectAll');
+          element._updateSelected([{}]);
+          assert.isTrue(spy.called);
+        });
+      });
+    });
+
+    suite('_selectAll()', () => {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+        element.data = DataGenerator.generateHistoryRequestsData({
+          requestsSize: 5
+        });
+      });
+
+      test('Sets all data selected', () => {
+        element._selectAll();
+        assert.isTrue(element.data.every((i) => i.selected));
+      });
+    });
+
+    suite('_toggleSelectAll()', () => {
+      let element;
+      setup(function() {
+        element = fixture('Basic');
+        element.data = DataGenerator.generateHistoryRequestsData({
+          requestsSize: 5
+        });
+      });
+
+      test('Does nothing when no selected items', () => {
+        element.selectedItems = undefined;
+        element._toggleSelectAll();
+      });
+
+      test('Does nothing when no data', () => {
+        element.selectedItems = [{}];
+        element.data = undefined;
+        element._toggleSelectAll();
+      });
+
+      test('Selecting all - selection length match', () => {
+        element.data[0].selected = undefined;
+        element.selectedItems = element.data;
+        element._toggleSelectAll(true);
+        assert.isUndefined(element.data[0].selected);
+      });
+
+      test('Selecting all - selects all', () => {
+        element.selectedItems = [];
+        element._toggleSelectAll(true);
+        assert.isTrue(element.data[0].selected);
+      });
+
+      test('Selecting none - none selected', () => {
+        element.selectedItems = [];
+        element._toggleSelectAll(false);
+        assert.isTrue(element.data[0].selected);
+      });
+
+      test('Selecting none - all selected', () => {
+        element.selectedItems = element.data;
+        element._toggleSelectAll(false);
+        assert.isFalse(element.data[0].selected);
+      });
+    });
+
+    suite('_onSelectItem()', () => {
+      let element;
+      setup(function(done) {
+        element = fixture('Basic');
+        element.data = DataGenerator.generateHistoryRequestsData({
+          requestsSize: 1
+        });
+        flush(() => done());
+      });
+
+      test('Deselects the item', () => {
+        const node = element.shadowRoot.querySelector('.list-item paper-icon-item');
+        MockInteractions.tap(node);
+        assert.isFalse(element.data[0].selected);
+      });
+
+      test('Selectes the item', () => {
+        element.data[0].selected = false;
+        const node = element.shadowRoot.querySelector('.list-item paper-icon-item');
+        MockInteractions.tap(node);
+        assert.isTrue(element.data[0].selected);
+      });
+
+      test('Ignores other elements than list items', () => {
+        const node = element.shadowRoot.querySelector('header');
+        MockInteractions.tap(node);
+        assert.isTrue(element.data[0].selected);
+      });
+    });
+    </script>
+
+  </body>
+</html>