Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle Custom Location #1

Closed
GeekMasher opened this issue Mar 31, 2022 · 2 comments
Closed

Bundle Custom Location #1

GeekMasher opened this issue Mar 31, 2022 · 2 comments

Comments

@GeekMasher
Copy link
Collaborator

Right now the Action pulls from the github/codeql-action repository. It would be great to be able to point to an external CodeQL bundle created by the community so that if a user wants to build on another bundle, you could specify it.

Solution

The values in the bundle.ts should come from the action.yml (default value is github/codeql-action).

- name: CodeQL bundle
    id: codeql-bundle
    uses: advanced-security/codeql-bundle-action@main
    with:
        packs: "geekmasher/python"
        bundle: advanced-security/codeql-queries
        # or a link?
        bundle: https://s3.amazonaws.com/<bucket>/<object>

This also helps if users store a version on CodeQL Bundle already in GitHub Packages, S3 bucket, Artifactory, etc.

Suggestions for other solutions are welcome too.

@rvermeulen
Copy link
Contributor

After giving this some thought I think we should have the bundle either be a public url or a local path.

Then all the various authentication schemes can be excluded from this action which provides the most flexibility. That is, before this action add a step to download the bundle through any means (e.g., S3, Azure Blob, ...) and make it available to this action.

@rvermeulen
Copy link
Contributor

Since version 2.0 you can obtain a bundle from any location before customizing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants