Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tabs inside of multi stage forms #108

Open
4 tasks
mishterk opened this issue Jul 20, 2022 · 1 comment
Open
4 tasks

Add support for tabs inside of multi stage forms #108

mishterk opened this issue Jul 20, 2022 · 1 comment

Comments

@mishterk
Copy link
Member

mishterk commented Jul 20, 2022

When using tabs to organise fields inside a multi stage form, the tabs aren't hidden/shown depending on the form page. Instead, the tabs all appear at the bottom of the form. Interestingly, the tabs retain their functionality — i.e; when on the correct page, the field visibility will change when tabs are use — they just aren't hidden when on a page that doesn't have the tabs.

I took a look at the JS and the logic is really controlling visibility of elements with class .acf-field. This doesn't factor in tabs because they have a class .acf-tab-wrap.

  • Make sure .acf-tab-wrap is factored into the fields list
  • Test to see if tabs are hidden/shown on page change
  • Test tab functionality works as expected after the change
  • Follow up on this ticket.
@mishterk mishterk self-assigned this Jul 20, 2022
@mishterk mishterk added this to the 1.10.0 milestone Jul 20, 2022
@mishterk
Copy link
Member Author

Did a little testing on this front and found a way but needs some further testing and refinement. Stashed locally under 'Tab support'. Will look into this for 1.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant