Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should sierra template use sierra speech style? #36

Open
ericoporto opened this issue Oct 4, 2022 · 6 comments
Open

Should sierra template use sierra speech style? #36

ericoporto opened this issue Oct 4, 2022 · 6 comments

Comments

@ericoporto
Copy link
Member

ericoporto commented Oct 4, 2022

<SpeechStyle>Lucasarts</SpeechStyle>

Is there a particular reason for this? Has it always been like this?

Edit:

<SpeechStyle>Lucasarts</SpeechStyle>

Turns out it's been like this since the first commit. That's a bit unintuitive, but I guess it's one the things that are kept for historical purposes.

@morganwillcock
Copy link
Member

Maybe it should be changed.

It probably wasn't considered when the template was renamed, but now the description doesn't match what it does. I think that would be OK if there is a second template that demonstrates the other style.

@ericoporto ericoporto reopened this Oct 7, 2022
@ericoporto
Copy link
Member Author

I just checked and VerbCoin, BASS and Tumbleweed also use LucasArts speech style.

@ericoporto ericoporto changed the title Why sierra template speech style is lucas arts? Should sierra template use sierra speech style? Oct 7, 2022
@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Oct 7, 2022

Of course, because that's the simpliest possible style where you do not have to provide any other graphical assets; so it works well as default and for a quick prototyping.

For sierra-speech you need to have at least proper speech views, otherwise it won't work and display la speech again.

@morganwillcock
Copy link
Member

Maybe someone would be willing to make the additional speech views so that the same "asset pack" could potentially work across every template (and eventually in a modular future, allow easy switching between the styles)?

@ivan-mogilko
Copy link
Contributor

Maybe someone would be willing to make the additional speech views so that the same "asset pack" could potentially work across every template (and eventually in a modular future, allow easy switching between the styles)?

Agh, we should've posted this request on forums, nobody sees this here.
I will do this now.

@ivan-mogilko
Copy link
Contributor

But there's a problem to keep in mind: you cannot have these portraits assigned to a SpeechView and have Lucas-arts speech, because then they will be displayed as a character animation.

How do you do a switch between the styles gracefully then? Looks like this would require some setup in game_start, like a selection between two speech views. This will additionally complicate a template's script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants