Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize uploaded images #12

Closed
lorado opened this issue Apr 28, 2019 · 8 comments
Closed

Resize uploaded images #12

lorado opened this issue Apr 28, 2019 · 8 comments
Assignees

Comments

@lorado
Copy link
Contributor

lorado commented Apr 28, 2019

Hi, as I already mentioned - great work, thanks for the library!

I thought about possible improvements. Would it be possible to add support for spatie medialibrary? Resize/Multiple sizes of images would become so easy.

Alternatively some resize params would be nice, like in advanced image field

What do yo think?

@advoor advoor self-assigned this May 1, 2019
@advoor
Copy link
Owner

advoor commented May 4, 2019

@lorado I do like the idea, but not sure how the integration would work, specially with it having it's own migration and configuration options.

For image manipulation looks like the media library uses spatie/image , so I could integrate that quite easily, giving the ability to define different sizes?

@lorado
Copy link
Contributor Author

lorado commented May 5, 2019

I didn't dig there deep, but it seems, that probably usage of spatie/image would be enough.

For image manipulation looks like the media library uses spatie/image , so I could integrate that quite easily, giving the ability to define different sizes?

Yeah, go for it =)

@advoor
Copy link
Owner

advoor commented May 22, 2019

Hey @lorado, @mpanius finally got some time to work on this!

#15 - I'll do a release this weekend after I've tested this a bit more, but it would be good to get some initial feedback. Not tested with the S3 driver, but I think it should work just fine.

@lorado
Copy link
Contributor Author

lorado commented May 23, 2019

Oh oh! That is awesome. I am currently developing one project, where I use your lib. Unfortunately for you I can test local uploads only. I don't use S3...
When I get time this weekend, I will also test a little bit your branch ;)

@advoor
Copy link
Owner

advoor commented May 27, 2019

Tested a bit more and it looked good enough for a release :) Let me know if you have any issues!

@advoor advoor closed this as completed May 27, 2019
@lorado
Copy link
Contributor Author

lorado commented Jun 1, 2019

Just a quick respond: This feature works well for me! Thank you very much!

@mira-thakkar
Copy link

mira-thakkar commented Mar 19, 2020

@lorado hey have you used s3 driver with this package & media library?
i am facing some issues with it, so it would be very helpful to me if you can give some insight on it ?

@lorado
Copy link
Contributor Author

lorado commented Mar 19, 2020

@mira-thakkar hi, I was using local storage driver. Never tried s3, so can't help you there, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants