Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Upgrade to Node 17 (Update OpenSSL) #1436

Closed
asheingold opened this issue Jan 23, 2023 · 3 comments
Closed

[Enhancement]: Upgrade to Node 17 (Update OpenSSL) #1436

asheingold opened this issue Jan 23, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@asheingold
Copy link

Describe the issue

When building with Node > 17.0, OpenSSLthrows ERR_OSSL_EVP_UNSUPPORTED. This is due to:

https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V17.md#17.0.0

This should be upgraded.

Steps to reproduce the issue

  1. Follow the build instructions.
  2. When generating the static files (npm run generate in the client directory), it breaks.

Audiobookshelf version

2.2.12

How are you running audiobookshelf?

Built from source

@asheingold asheingold added the bug Something isn't working label Jan 23, 2023
@advplyr advplyr changed the title [Bug]: Update OpenSSL [Enhancement]: Upgrade to Node 17 (Update OpenSSL) Jan 23, 2023
@advplyr advplyr added enhancement New feature or request and removed bug Something isn't working labels Jan 23, 2023
@advplyr
Copy link
Owner

advplyr commented Jan 23, 2023

We are currently on Node 16 still

@asheingold
Copy link
Author

We are currently on Node 16 still

I'll close this and update the discussion that it should be build with Node 16, not Node 16 or higher.

#259

@advplyr
Copy link
Owner

advplyr commented Jan 25, 2023

I just noticed that Node 17 is no longer being maintained so the next Node version we would upgrade to is 18.

https://github.com/nodejs/release#release-schedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants