Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (Match tab) If Search Title or Author contain &, search query is incorrectly encoded #2128

Closed
mikiher opened this issue Sep 20, 2023 · 1 comment · Fixed by #2129
Closed
Labels
bug Something isn't working

Comments

@mikiher
Copy link
Contributor

mikiher commented Sep 20, 2023

Describe the issue

In the match tab, when either Search Title or Author fields contain an ampersand character, the search query is incorrectly encoded, and an incorrect search url is sent to the server.

Steps to reproduce the issue

  1. Open Match tab for any book

  2. Set Search Title to "a&b" and Author to ""

  3. Click "Search"
    Expected search URL: http://localhost:3333/api/search/books?provider=audible&fallbackTitleOnly=1&title=a%26b
    Actual search URL: http://localhost:3333/api/search/books?provider=audible&fallbackTitleOnly=1&title=a&b

  4. Open Match tab for any book

  5. Set Search Title to "a" and Author to "b&c"

  6. Click "Search"
    Expected search URL: http://localhost:3333/api/search/books?provider=audible&fallbackTitleOnly=1&title=a&author=b%26c
    Actual search URL: http://localhost:3333/api/search/books?provider=audible&fallbackTitleOnly=1&title=a&author=b&c

Audiobookshelf version

v2.4.2

How are you running audiobookshelf?

Built from source

@advplyr
Copy link
Owner

advplyr commented Sep 30, 2023

Fixed in v2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants