Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined not handled properly #1091

Closed
jakinluk opened this issue Jun 28, 2023 · 1 comment
Closed

undefined not handled properly #1091

jakinluk opened this issue Jun 28, 2023 · 1 comment

Comments

@jakinluk
Copy link

jakinluk commented Jun 28, 2023

https://github.com/commercetools/commercetools-adyen-integration/blob/bc2c28fd61a2b0dd3c63ccb50e05c96caa96b7c9/notification/src/handler/notification/notification.handler.js#L57

payment might be undefined then the condition evaluates to true
this is causing an unhandled non-repeatable error thrown here https://github.com/commercetools/commercetools-adyen-integration/blob/bc2c28fd61a2b0dd3c63ccb50e05c96caa96b7c9/notification/src/handler/notification/notification.handler.js#L73

resulting in an invalid response returned to Adyen

@merijndebeer-adyen
Copy link
Collaborator

Dear reporter, we would like to notify you that the Adyen x CommerceTools integration has changed ownership. From July 1st 2023, Adyen has taken over support / maintenance tasks for this integration from CommerceTools. Thank you for your product feedback. We will take your suggestion into consideration and prioritize accordingly. If you are experiencing any ongoing issues with this integration please contact Adyen Support and we will make sure you will get the answers you need to get going.

@merijndebeer-adyen merijndebeer-adyen closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants