Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Platform Notifications/Types #64

Closed
nirajjayant opened this issue Jun 10, 2020 · 2 comments
Closed

Supporting Platform Notifications/Types #64

nirajjayant opened this issue Jun 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@nirajjayant
Copy link

Is your feature request related to a problem? Please describe.
Can we use the open API generator to also generate strongly typed types for the Platform notifications?
https://docs.adyen.com/api-explorer/#/NotificationService/v5/overview
I think the Content field will initially be pretty cumbersome so I'm not sure if the generator you used would be good for this.

Describe the solution you'd like
Use the open-api generator to generate types for platform notifications

Describe alternatives you've considered
I initially was going to submit a PR using the existing notifications.NotificationRequestItemData but I noticed there were actually a few discrepancies

Additionally, we can just build those models on our side for decoding but would be great to consolidate in library. I'm also happy to help build this!

Additional context
N/A

@nirajjayant nirajjayant added the enhancement New feature or request label Jun 10, 2020
@KadoBOT
Copy link
Contributor

KadoBOT commented Jun 11, 2020

Hi @nirajjayantbolt

This is something that we have in our scope (see #46 and #47). We will start working on it really soon.

@nirajjayant
Copy link
Author

@KadoBOT awesome! Let me know if I can help! But let me close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants