Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Extend AdyenCheckout locale typings #364

Closed
nklaasse opened this issue Oct 2, 2020 · 2 comments
Closed

[FEAT] Extend AdyenCheckout locale typings #364

nklaasse opened this issue Oct 2, 2020 · 2 comments
Assignees
@pabloai
Labels
Enhancement New feature or request

Comments

@nklaasse
Copy link

nklaasse commented Oct 2, 2020

When configuring AdyenCheckout options, the locale key is typed from the locales Adyen supports translations for. Since we should be able to add any locale we want, which might required to integrate our own translations, it should be possible to use our own locales beside the supported ones. As an example, using a locale such as uk-UA is not possible at this moment.

https://github.com/Adyen/adyen-web/tree/master/packages/lib/src/language/locales
@nklaasse nklaasse added the Enhancement New feature or request label Oct 2, 2020
@pabloai pabloai self-assigned this Oct 2, 2020
@pabloai
Copy link
Contributor

pabloai commented Oct 2, 2020

Hi @nklaasse, thanks for the report.
Good catch, I'll work on a fix.

@pabloai pabloai mentioned this issue Oct 2, 2020
Merged
@pabloai
Copy link
Contributor

pabloai commented Oct 2, 2020

The fix was merged and will be included in our next release.
Let us know if there's anything else. Cheers!

@pabloai pabloai closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pabloai pabloai

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pabloai @nklaasse