Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only send messages when socket is open #25

Closed
pandeiro opened this issue Jul 22, 2015 · 1 comment
Closed

Only send messages when socket is open #25

pandeiro opened this issue Jul 22, 2015 · 1 comment

Comments

@pandeiro
Copy link
Contributor

Currently adzerk.boot-reload.websocket/transmit fires .send unconditionally; checking that the socket is open with adzerk.boot-reload.websocket/open? first would only send messages when the socket is actually open.

The use-case for this is when boot-reload is loaded in browser environments (e.g. headless browsers) that may not have full websocket support, for instance in testing. Since boot-cljs doesn't currently support multiple :optimizations :none builds (and boot-reload would try to add itself to each .cljs.edn spec anyway, as currently written), this change would facilitate doing both development and testing with a single build even if it includes boot-reload.

@martinklepsch
Copy link
Contributor

Closed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants