Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign description incorrect? #26

Closed
tonovotny opened this issue Dec 7, 2016 · 3 comments
Closed

assign description incorrect? #26

tonovotny opened this issue Dec 7, 2016 · 3 comments
Labels
bug

Comments

@tonovotny
Copy link
Contributor

Docs says that assign is always returning a new, immutable object which I believe is not true since #22
@aearly
Copy link
Owner

aearly commented Dec 7, 2016

Yes, that is slightly incorrect now. I'd be open to a PR that clarifies.

@aearly aearly added the bug label Dec 7, 2016
@tonovotny tonovotny mentioned this issue Dec 8, 2016
Merged
@tonovotny
Copy link
Contributor Author

tonovotny commented Dec 8, 2016 •
edited
Loading

After some thinking I think it's enough (in the context of whole docs) to remove the part about "always new object".

@aearly
Copy link
Owner

aearly commented Dec 8, 2016

Fixed in #27

@aearly aearly closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aearly @tonovotny