Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdroid build #81

Closed
ghost opened this issue Mar 4, 2020 · 9 comments
Closed

Fdroid build #81

ghost opened this issue Mar 4, 2020 · 9 comments

Comments

@ghost
Copy link

ghost commented Mar 4, 2020

Hello , Dev
Thangs for this great app ,but the last update on fdroid v2.4 , so won't you update the fdroid build to latest one like PS and github ?

@Aefyr
Copy link
Owner

Aefyr commented Mar 4, 2020

F-Droid's bot builds apps for their repository, but it's failing to build SAI. Previously it was due to Shizuku dependency being in a custom repo, but now it can't parse build.gradle for some reason. Someone made an issue to resolve that, but it's been kinda abandoned.

@licaon-kter
Copy link

licaon-kter commented Mar 4, 2020

As the issue there says, are those libs unavailable in a trusted repo or can't be build before building the app?

I can fix the Gradle error, but still won't build.

Yup #43 (comment)

If Shizuku is not FOSS we can't build it.

@Aefyr
Copy link
Owner

Aefyr commented Mar 4, 2020

Yeah, Shizuku's license only appears in publish.gradle indeed. Thanks for opening an issue in their repo

@licaon-kter
Copy link

@Aefyr
Copy link
Owner

Aefyr commented Mar 30, 2020

Thanks, I've removed custom repo and updated Shizuku API dependency in 375e5d4

@TPS
Copy link

TPS commented Mar 30, 2020

Just to confirm, is the Shizuku license resolved satisfactorily enough for F-droid being ok w/ SAI's legality?

@TPS
Copy link

TPS commented Apr 3, 2020

I guess so, as v3.9 hit the main F-Droid repo on 3-31!

@licaon-kter
Copy link

@TPS legality? Do tell more

@Aefyr
Copy link
Owner

Aefyr commented Apr 3, 2020

I guess so, as v3.9 hit main F-Droid repo on 3-31!

Oh, I didn't notice, guess this issue is resolved then

@Aefyr Aefyr closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants