Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding error in altitude conversion? #61

Closed
drmrbrewer opened this issue Jan 30, 2023 · 2 comments
Closed

Rounding error in altitude conversion? #61

drmrbrewer opened this issue Jan 30, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@drmrbrewer
Copy link

Shouldn't 3049 InHg convert to 1033 hPa rather than 1032 hPa in this example? It converts to 1032.51 with greater precision.

@aeharding aeharding added the bug Something isn't working label Jan 30, 2023
@clioh
Copy link

clioh commented Feb 2, 2023

Would love to have the option of returning in inches of mercury as well

@aeharding
Copy link
Owner

@clioh that actually will be addressed with #59. metar-taf-parser will return the value in the unit provided on the metar (InHg or hPA depending). And then the user can convert themselves, if that's wanted. :)

@drmrbrewer assuming that this will be handled in #59, it should make this conversion bug irrelevant (since there will be no conversion). So I am going to close this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants