Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 DESIGNER HELP NEEDED: New calendar icons! #197

Closed
aeharding opened this issue Jul 2, 2023 · 6 comments · Fixed by #524
Closed

🚨 DESIGNER HELP NEEDED: New calendar icons! #197

aeharding opened this issue Jul 2, 2023 · 6 comments · Fixed by #524
Labels
help wanted Extra attention is needed

Comments

@aeharding
Copy link
Owner

aeharding commented Jul 2, 2023

Hi there!

Paging all designers that build SVGs!

Apollo had some really nice calendar items for "top" sorts.

This is important, because when sorting by top, the different icon shows in the header of wefwef that allows you to see which "top" sort you have selected.

Example Apollo options:

image

We obviously don't want to exactly copy. Ionic has a nice MIT-licensed calendar SVG we can use as a base:

https://github.com/aeharding/wefwef/assets/2166114/03c8a1df-2563-4786-9333-d2d6d7e38022

Then we just need to style the contents of the calendar item. :)

Here's all of the "top" states in wefwef. We need different icons for each option as SVGs.

@DCarlson12
Copy link

I can try to whip something up. Can I do the same number style with some ideas for the 6 and 12 hour marks?

Was thinking of putting 1/4 and 1/2 for the 6 and 12 hour ones respectively.

@Bahnburner
Copy link

If I can find time over the holiday, I'll knock these out. It shouldn't take long at all.

@aeharding aeharding added the help wanted Extra attention is needed label Jul 4, 2023
@tilden
Copy link
Contributor

tilden commented Jul 24, 2023

Hi there! In case no one has finished this yet, I made a concept for how this could look. I was thinking that instead of fully following the Apollo model of using a calendar icon as the basis for every time unit, it could be worthwhile to differentiate the choices further by using different base icons for different time units (clock for hour, calendar for days, etc.) What do you think?

image

@rsammelson
Copy link
Contributor

I really like this look!

@aeharding
Copy link
Owner Author

@tilden agreed, these are perfect. can you make a PR? Thanks!

@tilden
Copy link
Contributor

tilden commented Jul 24, 2023

@aeharding Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants