Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merkle Hashing #19

Closed
samgranger opened this issue Jan 5, 2018 · 7 comments
Closed

Merkle Hashing #19

samgranger opened this issue Jan 5, 2018 · 7 comments

Comments

@samgranger
Copy link

samgranger commented Jan 5, 2018 •
edited

I see that you use MD5 for merkle hashing, why not SHA?

See: https://github.com/AElfProject/AElf/blob/ff73574afaf9ecf64f98ff472da4247c6586a209/AElf.Kernel/ExtensionMethods.cs
@xtaci
Copy link
Contributor

xtaci commented Jan 5, 2018

it should be SHA-256.
@EanCuznaivy

@EanCuznaivy
Copy link
Contributor

Thanks.
Already changed to SHA-256 yesterday in new PR.

@loning
Copy link
Contributor

loning commented Jan 5, 2018 via email

@samgranger
Copy link
Author

Wouldn't SHA-3 / Keccak be a better alternative?

@xtaci
Copy link
Contributor

xtaci commented Jan 5, 2018

yes, sure , but interfaces are better

@samsoull
Copy link

samsoull commented Feb 3, 2018

Good

@mjostani2002
Copy link

Totally agree

@samfrb samfrb closed this as completed Mar 7, 2018
shiwk added a commit that referenced this issue Apr 4, 2018
@shiwk
Merge pull request #19 from AElfProject/feature-docs
83b923d 
Feature docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@loning @samgranger @xtaci @EanCuznaivy @samfrb @samsoull @mjostani2002